pkg/sweeper/ #33

New issue

Closed

opened 2026-03-28 04:20:38 +00:00 by mfreeman451 · 0 comments

mfreeman451 commented

2026-03-28 04:20:38 +00:00

Owner

Imported from GitHub.

Original GitHub issue: #70
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/70
Original created: 2025-01-20T03:37:55Z

The Reporter interface is defined but not used.
The SweepService interface is defined but not used.
The relationship between these interfaces could be made clearer with better documentation.
The Result struct includes a Target field but also includes fields that duplicate the target information.
The SweepSummary struct includes Hosts and Ports fields but these are potentially expensive to generate and not used elsewhere in the codebase.
The Config struct contains fields that are used by different components (e.g., ICMPCount is only used by ICMPScanner).

Imported from GitHub. Original GitHub issue: #70 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/70 Original created: 2025-01-20T03:37:55Z --- - [x] The Reporter interface is defined but not used. - [x] The SweepService interface is defined but not used. - [x] The relationship between these interfaces could be made clearer with better documentation. - [x] The Result struct includes a Target field but also includes fields that duplicate the target information. - [x] The SweepSummary struct includes Hosts and Ports fields but these are potentially expensive to generate and not used elsewhere in the codebase. - [x] The Config struct contains fields that are used by different components (e.g., ICMPCount is only used by ICMPScanner).

Rows
Columns