Chore/bazel cleanup #3040

Merged
mfreeman451 merged 46 commits from refs/pull/3040/head into staging 2026-03-12 20:30:23 +00:00
mfreeman451 commented 2026-03-11 03:21:34 +00:00 (Migrated from github.com)
Owner

Imported from GitHub pull request.

Original GitHub pull request: #3027
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/3027
Original created: 2026-03-11T03:21:34Z
Original updated: 2026-03-12T20:30:25Z
Original head: carverauto/serviceradar:chore/bazel-cleanup
Original base: staging
Original merged: 2026-03-12T20:30:23Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Code checklist before requesting a review

  • I have signed the DCO?
  • The build completes without errors?
  • All tests are passing when running make test?
Imported from GitHub pull request. Original GitHub pull request: #3027 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/3027 Original created: 2026-03-11T03:21:34Z Original updated: 2026-03-12T20:30:25Z Original head: carverauto/serviceradar:chore/bazel-cleanup Original base: staging Original merged: 2026-03-12T20:30:23Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?
marvin-hansen commented 2026-03-11 17:03:27 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR comment.

Original author: @marvin-hansen
Original URL: https://github.com/carverauto/serviceradar/pull/3027#issuecomment-4040712163
Original created: 2026-03-11T17:03:27Z

Okay, I should get the review through within 24h unless I find a major problem like the one that kicked it off.

Imported GitHub PR comment. Original author: @marvin-hansen Original URL: https://github.com/carverauto/serviceradar/pull/3027#issuecomment-4040712163 Original created: 2026-03-11T17:03:27Z --- Okay, I should get the review through within 24h unless I find a major problem like the one that kicked it off.
marvin-hansen commented 2026-03-12 03:04:19 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR comment.

Original author: @marvin-hansen
Original URL: https://github.com/carverauto/serviceradar/pull/3027#issuecomment-4043585874
Original created: 2026-03-12T03:04:19Z

LGTM. The patch of mix_relaase gets the job done. I have to think deeper about a complete build refactoring, but this will take some time given how tangled up the Elixier build has become. Will fill a separate issue once I got an idea what to do about it.

Imported GitHub PR comment. Original author: @marvin-hansen Original URL: https://github.com/carverauto/serviceradar/pull/3027#issuecomment-4043585874 Original created: 2026-03-12T03:04:19Z --- LGTM. The patch of mix_relaase gets the job done. I have to think deeper about a complete build refactoring, but this will take some time given how tangled up the Elixier build has become. Will fill a separate issue once I got an idea what to do about it.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!3040
No description provided.