Feat/netflow analytics #2875

Merged
mfreeman451 merged 17 commits from refs/pull/2875/head into staging 2026-02-09 02:45:12 +00:00
mfreeman451 commented 2026-02-08 04:09:38 +00:00 (Migrated from github.com)
Owner

Imported from GitHub pull request.

Original GitHub pull request: #2730
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2730
Original created: 2026-02-08T04:09:38Z
Original updated: 2026-02-09T02:45:14Z
Original head: carverauto/serviceradar:feat/netflow-analytics
Original base: staging
Original merged: 2026-02-09T02:45:12Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Code checklist before requesting a review

  • I have signed the DCO?
  • The build completes without errors?
  • All tests are passing when running make test?
Imported from GitHub pull request. Original GitHub pull request: #2730 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2730 Original created: 2026-02-08T04:09:38Z Original updated: 2026-02-09T02:45:14Z Original head: carverauto/serviceradar:feat/netflow-analytics Original base: staging Original merged: 2026-02-09T02:45:12Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?
mfreeman451 commented 2026-02-08 04:48:19 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2730#discussion_r2778565542
Original created: 2026-02-08T04:48:19Z
Original path: rust/srql/src/query/flows.rs
Original line: 154

this is ugly and probably shouldn't live in here

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2730#discussion_r2778565542 Original created: 2026-02-08T04:48:19Z Original path: rust/srql/src/query/flows.rs Original line: 154 --- this is ugly and probably shouldn't live in here
mfreeman451 commented 2026-02-08 04:49:13 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2730#discussion_r2778566098
Original created: 2026-02-08T04:49:13Z
Original path: rust/srql/src/query/flows.rs
Original line: 154

could just as easily have a map on the web-ng where it was more maintainable or derived from user supplied data

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2730#discussion_r2778566098 Original created: 2026-02-08T04:49:13Z Original path: rust/srql/src/query/flows.rs Original line: 154 --- could just as easily have a map on the web-ng where it was more maintainable or derived from user supplied data
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!2875
No description provided.