carverauto/serviceradar

Fork 0

2293 feat rbac buildereditor #2860

Merged

mfreeman451 merged 33 commits from refs/pull/2860/head into staging

2026-02-06 18:48:27 +00:00

mfreeman451 commented

2026-02-06 01:46:30 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2713
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2713
Original created: 2026-02-06T01:46:30Z
Original updated: 2026-02-06T18:48:29Z
Original head: carverauto/serviceradar:2293-feat-rbac-buildereditor
Original base: staging
Original merged: 2026-02-06T18:48:27Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #2713 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2713 Original created: 2026-02-06T01:46:30Z Original updated: 2026-02-06T18:48:29Z Original head: carverauto/serviceradar:2293-feat-rbac-buildereditor Original base: staging Original merged: 2026-02-06T18:48:27Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

mfreeman451 commented

2026-02-06 05:19:55 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2772339213
Original created: 2026-02-06T05:19:55Z
Original path: elixir/serviceradar_core/lib/serviceradar/identity/changes/normalize_permission_keys.ex
Original line: 2

this whole thing needs to go

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2772339213 Original created: 2026-02-06T05:19:55Z Original path: elixir/serviceradar_core/lib/serviceradar/identity/changes/normalize_permission_keys.ex Original line: 2 --- this whole thing needs to go

mfreeman451 commented

2026-02-06 05:20:45 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2772340931
Original created: 2026-02-06T05:20:45Z
Original path: elixir/serviceradar_core/lib/serviceradar/identity/rbac/catalog.ex
Original line: 350

why do we have deprecated aliases in here?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2772340931 Original created: 2026-02-06T05:20:45Z Original path: elixir/serviceradar_core/lib/serviceradar/identity/rbac/catalog.ex Original line: 350 --- why do we have deprecated aliases in here?

mfreeman451 commented

2026-02-06 15:38:33 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2774754695
Original created: 2026-02-06T15:38:33Z
Original path: elixir/serviceradar_core/lib/serviceradar/monitoring/alert.ex
Original line: 343

i wish we didnt have to just rely on the actor being nil and assuming it is for oban, why cant oban have its own actor or the actor be known instead of nil?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2774754695 Original created: 2026-02-06T15:38:33Z Original path: elixir/serviceradar_core/lib/serviceradar/monitoring/alert.ex Original line: 343 --- i wish we didnt have to just rely on the actor being nil and assuming it is for oban, why cant oban have its own actor or the actor be known instead of nil?

mfreeman451 commented

2026-02-06 15:43:24 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2774775379
Original created: 2026-02-06T15:43:24Z
Original path: web-ng/lib/serviceradar_web_ng_web/controllers/api/edge_controller.ex
Original line: 89

edge agents dont use spiffe

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2774775379 Original created: 2026-02-06T15:43:24Z Original path: web-ng/lib/serviceradar_web_ng_web/controllers/api/edge_controller.ex Original line: 89 --- edge agents dont use spiffe

mfreeman451 commented

2026-02-06 15:55:38 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2774828313
Original created: 2026-02-06T15:55:38Z
Original path: web-ng/lib/serviceradar_web_ng_web/live/settings/auth_users_live.ex
Original line: 580

need to get rid of these legacy profile checks

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2774828313 Original created: 2026-02-06T15:55:38Z Original path: web-ng/lib/serviceradar_web_ng_web/live/settings/auth_users_live.ex Original line: 580 --- need to get rid of these legacy profile checks

mfreeman451 commented

2026-02-06 17:24:13 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2775235032
Original created: 2026-02-06T17:24:13Z
Original path: web-ng/test/serviceradar_web_ng/inventory_test.exs
Original line: 29

why did we get rid of this?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2713#discussion_r2775235032 Original created: 2026-02-06T17:24:13Z Original path: web-ng/test/serviceradar_web_ng/inventory_test.exs Original line: 29 --- why did we get rid of this?