Update/ash framework cont2 #2620

Merged

mfreeman451 merged 6 commits from refs/pull/2620/head into testing

2025-12-29 03:51:01 +00:00

mfreeman451 commented

2025-12-28 19:16:24 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2211
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2211
Original created: 2025-12-28T19:16:24Z
Original updated: 2025-12-29T03:51:02Z
Original head: carverauto/serviceradar:update/ash_framework_cont2
Original base: testing
Original merged: 2025-12-29T03:51:01Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #2211 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2211 Original created: 2025-12-28T19:16:24Z Original updated: 2025-12-29T03:51:02Z Original head: carverauto/serviceradar:update/ash_framework_cont2 Original base: testing Original merged: 2025-12-29T03:51:01Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

mfreeman451 commented

2025-12-28 20:53:29 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2211#discussion_r2649922891
Original created: 2025-12-28T20:53:29Z
Original path: elixir/serviceradar_core/lib/serviceradar/actors/device_registry.ex
Original line: 137

need to fix this, not clear how this is being authorized

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2211#discussion_r2649922891 Original created: 2025-12-28T20:53:29Z Original path: elixir/serviceradar_core/lib/serviceradar/actors/device_registry.ex Original line: 137 --- need to fix this, not clear how this is being authorized

mfreeman451 commented

2025-12-28 20:55:54 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2211#discussion_r2649923930
Original created: 2025-12-28T20:55:54Z
Original path: elixir/serviceradar_core/lib/serviceradar/identity/changes/initialize_tenant_infrastructure.ex
Original line: 91

do we need this ? doesnt ash automatically handle this per-tenant schema stuff?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2211#discussion_r2649923930 Original created: 2025-12-28T20:55:54Z Original path: elixir/serviceradar_core/lib/serviceradar/identity/changes/initialize_tenant_infrastructure.ex Original line: 91 --- do we need this ? doesnt ash automatically handle this per-tenant schema stuff?