carverauto/serviceradar

Fork 0

OCSF device inventory schema alignment #2601

Merged

mfreeman451 merged 21 commits from refs/pull/2601/head into staging

2025-12-19 04:34:12 +00:00

mfreeman451 commented

2025-12-18 08:08:50 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2186
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2186
Original created: 2025-12-18T08:08:50Z
Original updated: 2025-12-19T04:34:13Z
Original head: carverauto/serviceradar:2177-feat-ocsf-device-inventory-schema-alignment
Original base: staging
Original merged: 2025-12-19T04:34:12Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #2186 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2186 Original created: 2025-12-18T08:08:50Z Original updated: 2025-12-19T04:34:13Z Original head: carverauto/serviceradar:2177-feat-ocsf-device-inventory-schema-alignment Original base: staging Original merged: 2025-12-19T04:34:12Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

mfreeman451 commented

2025-12-18 16:33:43 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2186#discussion_r2631775826
Original created: 2025-12-18T16:33:43Z
Original path: pkg/db/cnpg_unified_devices.go
Original line: 35

need to get rid of these maps

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2186#discussion_r2631775826 Original created: 2025-12-18T16:33:43Z Original path: pkg/db/cnpg_unified_devices.go Original line: 35 --- need to get rid of these maps

mfreeman451 commented

2025-12-18 18:06:10 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2186#discussion_r2632059694
Original created: 2025-12-18T18:06:10Z
Original path: pkg/registry/canon_simulation_test.go
Original line: 334

dont understand why this returns empty still?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2186#discussion_r2632059694 Original created: 2025-12-18T18:06:10Z Original path: pkg/registry/canon_simulation_test.go Original line: 334 --- dont understand why this returns empty still?

mfreeman451 commented

2025-12-18 18:07:22 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2186#discussion_r2632062669
Original created: 2025-12-18T18:07:22Z
Original path: rust/srql/src/models.rs
Original line: 68

need to get rid of the aliases

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2186#discussion_r2632062669 Original created: 2025-12-18T18:07:22Z Original path: rust/srql/src/models.rs Original line: 68 --- need to get rid of the aliases

mfreeman451 commented

2025-12-18 18:08:32 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2186#discussion_r2632066156
Original created: 2025-12-18T18:08:32Z
Original path: rust/srql/tests/fixtures/schema.sql
Original line: 44

not sure that we want serviceradar specific fields here, we break the schema.. cant we put these somewhere else?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2186#discussion_r2632066156 Original created: 2025-12-18T18:08:32Z Original path: rust/srql/tests/fixtures/schema.sql Original line: 44 --- not sure that we want serviceradar specific fields here, we break the schema.. cant we put these somewhere else?

mfreeman451 commented

2025-12-18 18:09:42 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2186#discussion_r2632069952
Original created: 2025-12-18T18:09:42Z
Original path: web-ng/lib/serviceradar_web_ng/api/device_controller.ex
Original line: 257

need to get rid of the aliases here and make sure we're not relying on them anywhere else

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2186#discussion_r2632069952 Original created: 2025-12-18T18:09:42Z Original path: web-ng/lib/serviceradar_web_ng/api/device_controller.ex Original line: 257 --- need to get rid of the aliases here and make sure we're not relying on them anywhere else