carverauto/serviceradar

Fork 0

Release/1 0 78 #2559

Merged

mfreeman451 merged 3 commits from refs/pull/2559/head into main

2025-12-14 19:32:36 +00:00

mfreeman451 commented

2025-12-14 17:57:52 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2120
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2120
Original created: 2025-12-14T17:57:52Z
Original updated: 2025-12-14T19:32:39Z
Original head: carverauto/serviceradar:release/1_0_78
Original base: main
Original merged: 2025-12-14T19:32:36Z by @mfreeman451

User description

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

PR Type

Enhancement, Bug fix

Description

Release version 1.0.78 with improved configuration management UI
Enhanced SNMP and network discovery configuration forms
Fixed kong-config image tag pinning in Helm charts
Improved Helm reproducibility by removing hardcoded image tags

Diagram Walkthrough

flowchart LR
  A["Version 1.0.77"] -->|"Release 1.0.78"| B["Updated Version Files"]
  B -->|"Configuration UI"| C["Mapper & SNMP Forms"]
  B -->|"Helm Chart Fix"| D["Kong-config Image Pinning"]
  C -->|"Better UX"| E["Poller Check Configuration"]
  D -->|"Reproducibility"| F["Tag & Pull Policy Control"]

File Walkthrough

Relevant files

Documentation

CHANGELOG

Added v1.0.78 release notes and features

CHANGELOG

Added v1.0.78 release notes with new features
Documented configuration management UI improvements
Noted Helm kong-config image tag pinning fix
Maintained previous v1.0.77 changelog entry

+11/-0

Configuration changes

VERSION `Bumped version to 1.0.78` VERSION Updated version number from 1.0.77 to 1.0.78	+1/-1
Chart.yaml `Updated Helm chart version numbers` helm/serviceradar/Chart.yaml Updated Helm chart version to 1.0.78 Updated appVersion to 1.0.78	+2/-2

Bug fix

core.yaml

Fixed kong-config image tag pinning in core

helm/serviceradar/templates/core.yaml

Replaced hardcoded latest tag with dynamic image tag helper
Changed imagePullPolicy from Always to dynamic helper function
Improved reproducibility for kong-config image in init container

+2/-2

kong.yaml

Fixed kong-config image tags in Kong deployment

helm/serviceradar/templates/kong.yaml

Replaced hardcoded latest tag with dynamic image tag helper in
render-kong-config
Replaced hardcoded latest tag with dynamic image tag helper in
kong-config-watcher
Changed imagePullPolicy from IfNotPresent to dynamic helper function
Improved consistency and reproducibility across all kong-config
containers

+4/-4

Imported from GitHub pull request. Original GitHub pull request: #2120 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2120 Original created: 2025-12-14T17:57:52Z Original updated: 2025-12-14T19:32:39Z Original head: carverauto/serviceradar:release/1_0_78 Original base: main Original merged: 2025-12-14T19:32:36Z by @mfreeman451 --- ### **User description** ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test? ___ ### **PR Type** Enhancement, Bug fix ___ ### **Description** - Release version 1.0.78 with improved configuration management UI - Enhanced SNMP and network discovery configuration forms - Fixed kong-config image tag pinning in Helm charts - Improved Helm reproducibility by removing hardcoded image tags ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Version 1.0.77"] -->|"Release 1.0.78"| B["Updated Version Files"] B -->|"Configuration UI"| C["Mapper & SNMP Forms"] B -->|"Helm Chart Fix"| D["Kong-config Image Pinning"] C -->|"Better UX"| E["Poller Check Configuration"] D -->|"Reproducibility"| F["Tag & Pull Policy Control"] ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td>Documentation</td><td><table> <tr> <td> <details> <summary>CHANGELOG<dd><code>Added v1.0.78 release notes and features</code>                                  </dd></summary> <hr> CHANGELOG <ul><li>Added v1.0.78 release notes with new features <li> Documented configuration management UI improvements <li> Noted Helm kong-config image tag pinning fix <li> Maintained previous v1.0.77 changelog entry</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2120/files#diff-ecec88c33adb7591ee6aa88e29b62ad52ef443611cba5e0f0ecac9b5725afdba">+11/-0</a>    </td> </tr> </table></td></tr><tr><td>Configuration changes</td><td><table> <tr> <td> <details> <summary>VERSION<dd><code>Bumped version to 1.0.78</code>                                                                  </dd></summary> <hr> VERSION - Updated version number from 1.0.77 to 1.0.78 </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2120/files#diff-7b60b8e351cbb80c47459ffe2c79f1a26404871f49294780fe47ad0e58c09350">+1/-1</a>      </td> </tr> <tr> <td> <details> <summary>Chart.yaml<dd><code>Updated Helm chart version numbers</code>                                              </dd></summary> <hr> helm/serviceradar/Chart.yaml - Updated Helm chart version to 1.0.78 - Updated appVersion to 1.0.78 </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2120/files#diff-5da50230d0b5d4b5e859c40708517b85481711881faaf741e74cd58aa99314f8">+2/-2</a>      </td> </tr> </table></td></tr><tr><td>Bug fix</td><td><table> <tr> <td> <details> <summary>core.yaml<dd><code>Fixed kong-config image tag pinning in core</code>                            </dd></summary> <hr> helm/serviceradar/templates/core.yaml <ul><li>Replaced hardcoded <code>latest</code> tag with dynamic image tag helper <li> Changed imagePullPolicy from <code>Always</code> to dynamic helper function <li> Improved reproducibility for kong-config image in init container</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2120/files#diff-06ab387d2c169d82a1de28b5e66c86f0417bd81b82a96246d0a2da8bfaa8d224">+2/-2</a>      </td> </tr> <tr> <td> <details> <summary>kong.yaml<dd><code>Fixed kong-config image tags in Kong deployment</code>                    </dd></summary> <hr> helm/serviceradar/templates/kong.yaml <ul><li>Replaced hardcoded <code>latest</code> tag with dynamic image tag helper in render-kong-config <li> Replaced hardcoded <code>latest</code> tag with dynamic image tag helper in kong-config-watcher <li> Changed imagePullPolicy from <code>IfNotPresent</code> to dynamic helper function <li> Improved consistency and reproducibility across all kong-config containers</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2120/files#diff-5e7ea00b7a92ae0d6dcc322daa292b71820fbab9826bd7f29ea98078765c60c4">+4/-4</a>      </td> </tr> </table></td></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2025-12-14 17:58:24 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2120#issuecomment-3651763130
Original created: 2025-12-14T17:58:24Z

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: No audit logs: The changes adjust container image tags and pull policies without adding or modifying any application logic that would log critical actions, so it's unclear whether critical actions are being audited. Referred Code `image: ghcr.io/carverauto/serviceradar-kong-config:{{ include "serviceradar.imageTag" (dict "Values" .Values "service" "kongConfig") }} imagePullPolicy: {{ include "serviceradar.imagePullPolicy" . }} command:` Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: No error handling: The new lines only change image tag and pull policy for init containers and do not demonstrate any error handling or edge case management, making compliance unverifiable from this diff. Referred Code `image: ghcr.io/carverauto/serviceradar-kong-config:{{ include "serviceradar.imageTag" (dict "Values" .Values "service" "kongConfig") }} imagePullPolicy: {{ include "serviceradar.imagePullPolicy" . }}` Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: User error detail: The diff does not modify user-facing error messages or logging; secure error handling cannot be verified based on the added Helm template lines. Referred Code `image: ghcr.io/carverauto/serviceradar-kong-config:{{ include "serviceradar.imageTag" (dict "Values" .Values "service" "kongConfig") }} imagePullPolicy: {{ include "serviceradar.imagePullPolicy" . }}` Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Input validation: The changes only affect deployment image tags and pull policies and do not show any input handling paths, so validation and secure data handling cannot be assessed from the new lines. Referred Code `image: ghcr.io/carverauto/serviceradar-kong-config:{{ include "serviceradar.imageTag" (dict "Values" .Values "service" "kongConfig") }} imagePullPolicy: {{ include "serviceradar.imagePullPolicy" . }} command:` Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2120#issuecomment-3651763130 Original created: 2025-12-14T17:58:24Z --- _You are nearing your monthly Qodo Merge usage quota. For more information, please visit [here](https://qodo-merge-docs.qodo.ai/installation/qodo_merge/#cloud-users)._ ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR: <table><tbody><tr><td colspan='2'>Security Compliance</td></tr> <tr><td>🟢</td><td><details><summary>No security concerns identified</summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'>Ticket Compliance</td></tr> <tr><td>⚪</td><td><details><summary>🎫 No ticket provided </summary> - [ ] Create ticket/issue  </details></td></tr> <tr><td colspan='2'>Codebase Duplication Compliance</td></tr> <tr><td>⚪</td><td><details><summary>Codebase context is not defined </summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'>Custom Compliance</td></tr> <tr><td rowspan=2>🟢</td><td> <details><summary>Generic: Meaningful Naming and Self-Documenting Code</summary> **Objective:** Ensure all identifiers clearly express their purpose and intent, making code self-documenting **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Secure Logging Practices</summary> **Objective:** To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td rowspan=4>⚪</td> <td><details> <summary>Generic: Comprehensive Audit Trails</summary> **Objective:** To create a detailed and reliable record of critical system actions for security analysis and compliance. **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2120/files#diff-5e7ea00b7a92ae0d6dcc322daa292b71820fbab9826bd7f29ea98078765c60c4R23-R25'>No audit logs</a>: The changes adjust container image tags and pull policies without adding or modifying any application logic that would log critical actions, so it's unclear whether critical actions are being audited. <details open><summary>Referred Code</summary> ```yaml image: ghcr.io/carverauto/serviceradar-kong-config:{{ include "serviceradar.imageTag" (dict "Values" .Values "service" "kongConfig") }} imagePullPolicy: {{ include "serviceradar.imagePullPolicy" . }} command: ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Robust Error Handling and Edge Case Management</summary> **Objective:** Ensure comprehensive error handling that provides meaningful context and graceful degradation **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2120/files#diff-06ab387d2c169d82a1de28b5e66c86f0417bd81b82a96246d0a2da8bfaa8d224R36-R37'>No error handling</a>: The new lines only change image tag and pull policy for init containers and do not demonstrate any error handling or edge case management, making compliance unverifiable from this diff. <details open><summary>Referred Code</summary> ```yaml image: ghcr.io/carverauto/serviceradar-kong-config:{{ include "serviceradar.imageTag" (dict "Values" .Values "service" "kongConfig") }} imagePullPolicy: {{ include "serviceradar.imagePullPolicy" . }} ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Secure Error Handling</summary> **Objective:** To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2120/files#diff-5e7ea00b7a92ae0d6dcc322daa292b71820fbab9826bd7f29ea98078765c60c4R90-R91'>User error detail</a>: The diff does not modify user-facing error messages or logging; secure error handling cannot be verified based on the added Helm template lines. <details open><summary>Referred Code</summary> ```yaml image: ghcr.io/carverauto/serviceradar-kong-config:{{ include "serviceradar.imageTag" (dict "Values" .Values "service" "kongConfig") }} imagePullPolicy: {{ include "serviceradar.imagePullPolicy" . }} ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Security-First Input Validation and Data Handling</summary> **Objective:** Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2120/files#diff-5e7ea00b7a92ae0d6dcc322daa292b71820fbab9826bd7f29ea98078765c60c4R23-R25'>Input validation</a>: The changes only affect deployment image tags and pull policies and do not show any input handling paths, so validation and secure data handling cannot be assessed from the new lines. <details open><summary>Referred Code</summary> ```yaml image: ghcr.io/carverauto/serviceradar-kong-config:{{ include "serviceradar.imageTag" (dict "Values" .Values "service" "kongConfig") }} imagePullPolicy: {{ include "serviceradar.imagePullPolicy" . }} command: ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td align="center" colspan="2"> - [ ] Update  </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant 🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label </details>

qodo-code-review[bot] commented

2025-12-14 17:59:11 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2120#issuecomment-3651763929
Original created: 2025-12-14T17:59:11Z

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Code Suggestions ✨

No code suggestions found for the PR.

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2120#issuecomment-3651763929 Original created: 2025-12-14T17:59:11Z --- _You are nearing your monthly Qodo Merge usage quota. For more information, please visit [here](https://qodo-merge-docs.qodo.ai/installation/qodo_merge/#cloud-users)._ ## PR Code Suggestions ✨ No code suggestions found for the PR.