carverauto/serviceradar

Fork 0

chore: release v1.0.70 #2549

Merged

mfreeman451 merged 1 commit from refs/pull/2549/head into main

2025-12-12 04:21:51 +00:00

mfreeman451 commented

2025-12-12 04:20:32 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2110
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2110
Original created: 2025-12-12T04:20:32Z
Original updated: 2025-12-12T04:21:54Z
Original head: carverauto/serviceradar:release/1_0_70
Original base: main
Original merged: 2025-12-12T04:21:51Z by @mfreeman451

User description

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

PR Type

Other

Description

Release v1.0.70 with Sysmon mTLS defaults
Edge onboarding fixes for security configuration
Query/runtime hardening improvements
Bazel npm repository synchronization automation

Diagram Walkthrough

flowchart LR
  A["v1.0.69"] -- "Release" --> B["v1.0.70"]
  B --> C["Sysmon mTLS defaults"]
  B --> D["Edge onboarding fixes"]
  B --> E["Core metric ingestion"]
  B --> F["npm links sync automation"]

File Walkthrough

Relevant files

Documentation

CHANGELOG

Add v1.0.70 release notes to changelog

CHANGELOG

Added v1.0.70 release notes with detailed feature list
Documents Sysmon mTLS defaults for bare-metal installations
Describes edge onboarding fixes and security improvements
Lists core metric ingestion enhancements and npm sync automation

+15/-0

Configuration changes

VERSION

Bump version to 1.0.70

VERSION

Updated version number from 1.0.69 to 1.0.70

+1/-1

Imported from GitHub pull request. Original GitHub pull request: #2110 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2110 Original created: 2025-12-12T04:20:32Z Original updated: 2025-12-12T04:21:54Z Original head: carverauto/serviceradar:release/1_0_70 Original base: main Original merged: 2025-12-12T04:21:51Z by @mfreeman451 --- ### **User description** ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test? ___ ### **PR Type** Other ___ ### **Description** - Release v1.0.70 with Sysmon mTLS defaults - Edge onboarding fixes for security configuration - Query/runtime hardening improvements - Bazel npm repository synchronization automation ___ ### Diagram Walkthrough ```mermaid flowchart LR A["v1.0.69"] -- "Release" --> B["v1.0.70"] B --> C["Sysmon mTLS defaults"] B --> D["Edge onboarding fixes"] B --> E["Core metric ingestion"] B --> F["npm links sync automation"] ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td>Documentation</td><td><table> <tr> <td> <details> <summary>CHANGELOG<dd><code>Add v1.0.70 release notes to changelog</code>                                      </dd></summary> <hr> CHANGELOG <ul><li>Added v1.0.70 release notes with detailed feature list <li> Documents Sysmon mTLS defaults for bare-metal installations <li> Describes edge onboarding fixes and security improvements <li> Lists core metric ingestion enhancements and npm sync automation</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2110/files#diff-ecec88c33adb7591ee6aa88e29b62ad52ef443611cba5e0f0ecac9b5725afdba">+15/-0</a>    </td> </tr> </table></td></tr><tr><td>Configuration changes</td><td><table> <tr> <td> <details> <summary>VERSION<dd><code>Bump version to 1.0.70</code>                                                                      </dd></summary> <hr> VERSION - Updated version number from 1.0.69 to 1.0.70 </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2110/files#diff-7b60b8e351cbb80c47459ffe2c79f1a26404871f49294780fe47ad0e58c09350">+1/-1</a>      </td> </tr> </table></td></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2025-12-12 04:20:51 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2110#issuecomment-3644845065
Original created: 2025-12-12T04:20:51Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: No code changes: The PR only updates CHANGELOG and VERSION without adding or modifying executable code, so audit trail compliance cannot be assessed from this diff. Referred Code # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New 1.0.70 - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: No identifiers added: Only documentation/version text was added; there are no new variables or functions to evaluate naming conventions. Referred Code # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New 1.0.70 - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: No runtime logic: The diff contains no executable logic; error handling and edge case management cannot be evaluated from CHANGELOG/VERSION updates. Referred Code # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New 1.0.70 - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: No user errors: There are no user-facing error paths introduced in this PR’s code diff to validate secure error handling. Referred Code # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New 1.0.70 - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: No logging added: No logging statements were added or modified; secure logging practices cannot be assessed from the provided diff. Referred Code # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New 1.0.70 - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: No input paths: The PR changes only documentation and versioning; there are no new inputs or data handling code to validate. Referred Code # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New 1.0.70 - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2110#issuecomment-3644845065 Original created: 2025-12-12T04:20:51Z --- ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR: <table><tbody><tr><td colspan='2'>Security Compliance</td></tr> <tr><td>🟢</td><td><details><summary>No security concerns identified</summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'>Ticket Compliance</td></tr> <tr><td>⚪</td><td><details><summary>🎫 No ticket provided </summary> - [ ] Create ticket/issue  </details></td></tr> <tr><td colspan='2'>Codebase Duplication Compliance</td></tr> <tr><td>⚪</td><td><details><summary>Codebase context is not defined </summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'>Custom Compliance</td></tr> <tr><td rowspan=6>⚪</td> <td><details> <summary>Generic: Comprehensive Audit Trails</summary> **Objective:** To create a detailed and reliable record of critical system actions for security analysis and compliance. **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2110/files#diff-ecec88c33adb7591ee6aa88e29b62ad52ef443611cba5e0f0ecac9b5725afdbaR1-R15'>No code changes</a>: The PR only updates CHANGELOG and VERSION without adding or modifying executable code, so audit trail compliance cannot be assessed from this diff. <details open><summary>Referred Code</summary> ```txt # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New **1.0.70** - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Meaningful Naming and Self-Documenting Code</summary> **Objective:** Ensure all identifiers clearly express their purpose and intent, making code self-documenting **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2110/files#diff-ecec88c33adb7591ee6aa88e29b62ad52ef443611cba5e0f0ecac9b5725afdbaR1-R15'>No identifiers added</a>: Only documentation/version text was added; there are no new variables or functions to evaluate naming conventions. <details open><summary>Referred Code</summary> ```txt # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New **1.0.70** - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Robust Error Handling and Edge Case Management</summary> **Objective:** Ensure comprehensive error handling that provides meaningful context and graceful degradation **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2110/files#diff-ecec88c33adb7591ee6aa88e29b62ad52ef443611cba5e0f0ecac9b5725afdbaR1-R15'>No runtime logic</a>: The diff contains no executable logic; error handling and edge case management cannot be evaluated from CHANGELOG/VERSION updates. <details open><summary>Referred Code</summary> ```txt # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New **1.0.70** - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Secure Error Handling</summary> **Objective:** To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2110/files#diff-ecec88c33adb7591ee6aa88e29b62ad52ef443611cba5e0f0ecac9b5725afdbaR1-R15'>No user errors</a>: There are no user-facing error paths introduced in this PR’s code diff to validate secure error handling. <details open><summary>Referred Code</summary> ```txt # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New **1.0.70** - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Secure Logging Practices</summary> **Objective:** To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2110/files#diff-ecec88c33adb7591ee6aa88e29b62ad52ef443611cba5e0f0ecac9b5725afdbaR1-R15'>No logging added</a>: No logging statements were added or modified; secure logging practices cannot be assessed from the provided diff. <details open><summary>Referred Code</summary> ```txt # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New **1.0.70** - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Security-First Input Validation and Data Handling</summary> **Objective:** Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2110/files#diff-ecec88c33adb7591ee6aa88e29b62ad52ef443611cba5e0f0ecac9b5725afdbaR1-R15'>No input paths</a>: The PR changes only documentation and versioning; there are no new inputs or data handling code to validate. <details open><summary>Referred Code</summary> ```txt # ServiceRadar v1.0.70 Sysmon bare-metal mTLS defaults, edge onboarding fixes, and query/runtime hardening. ## Whats New **1.0.70** - Sysmon checker packages for RPM/deb installs now ship with mTLS defaults (instead of SPIFFE) and look for certs/config in standard bare‑metal paths. - Edge onboarding for sysmon checkers fixed: defaults to mTLS when security mode is omitted, includes correct endpoint SANs, and installs certs with proper ownership/permissions. - Core now ingests sysmon metrics from any gRPC service named `sysmon-*`, preventing UI‑configured checks from going stale. - Sysmon checker implements `GetResults` (matching poller expectations) and builds from shared `monitoring.proto`. - SRQL adds `process_metrics` entity so UI Process Details queries no longer 400. - Bazel npm `__links` repos synced for React/Next CVE bumps; added `scripts/sync-npm-links.py` to automate future updates. - Short Go test timeout raised to avoid race/coverage flakiness. ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td align="center" colspan="2">   </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant 🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label </details>

qodo-code-review[bot] commented

2025-12-12 04:21:05 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2110#issuecomment-3644845445
Original created: 2025-12-12T04:21:05Z

PR Code Suggestions ✨

No code suggestions found for the PR.

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2110#issuecomment-3644845445 Original created: 2025-12-12T04:21:05Z --- ## PR Code Suggestions ✨ No code suggestions found for the PR.

qodo-code-review[bot] commented

2025-12-12 04:21:09 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2110#issuecomment-3644845553
Original created: 2025-12-12T04:21:09Z

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: test-go

Failed stage: Run Go Tests [❌]

Failure summary:

The action failed because go test ./... exited with a non-zero status (FAIL). While many packages
reported ok, the overall run ended with FAIL at line 328 and the workflow exited with code 1.
-
Repeated errors indicate the tests attempted to read a configuration file at
/etc/serviceradar/core.json and failed with open /etc/serviceradar/core.json: no such file or
directory (lines 256–267, 264–266). This likely caused one or more tests to fail or the suite to
consider the run unsuccessful.
- No explicit failing test name or stack trace is shown in the
provided snippet, but the missing config file appears to be the root cause during tests.

Relevant error logs:

1:  Runner name: 'arc-runner-set-2tp2m-runner-l5lhq'
2:  Runner group name: 'Default'
...

241:  github.com/carverauto/serviceradar/cmd/mapper		coverage: 0.0% of statements
242:  github.com/carverauto/serviceradar/cmd/poller		coverage: 0.0% of statements
243:  github.com/carverauto/serviceradar/cmd/sync		coverage: 0.0% of statements
244:  github.com/carverauto/serviceradar/cmd/tools/cnpg-migrate		coverage: 0.0% of statements
245:  github.com/carverauto/serviceradar/cmd/tools/config-sync		coverage: 0.0% of statements
246:  github.com/carverauto/serviceradar/cmd/tools/kv-sweep		coverage: 0.0% of statements
247:  github.com/carverauto/serviceradar/cmd/tools/waitforport		coverage: 0.0% of statements
248:  github.com/carverauto/serviceradar/internal/fastsum		coverage: 0.0% of statements
249:  ok  	github.com/carverauto/serviceradar/pkg/agent	3.393s	coverage: 1.3% of statements in ./...
250:  github.com/carverauto/serviceradar/pkg/checker		coverage: 0.0% of statements
251:  github.com/carverauto/serviceradar/pkg/checker/dusk		coverage: 0.0% of statements
252:  ok  	github.com/carverauto/serviceradar/pkg/checker/snmp	2.855s	coverage: 0.6% of statements in ./...
253:  ok  	github.com/carverauto/serviceradar/pkg/checker/sysmonosx	2.717s	coverage: 0.3% of statements in ./...
254:  github.com/carverauto/serviceradar/pkg/cli		coverage: 0.0% of statements
255:  -test.shuffle 1765513246221280598
256:  {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:46Z","message":"Failed to read configuration file"}
257:  {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:46Z","message":"Failed to read configuration file"}
258:  {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:47Z","message":"Failed to read configuration file"}
259:  {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:47Z","message":"Failed to read configuration file"}
260:  {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:48Z","message":"Failed to read configuration file"}
261:  {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:48Z","message":"Failed to read configuration file"}
262:  {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:49Z","message":"Failed to read configuration file"}
263:  coverage: 1.7% of statements in ./...
264:  {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:49Z","message":"Failed to read configuration file"}
265:  {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:49Z","message":"Failed to read configuration file"}
266:  {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:50Z","message":"Failed to read configuration file"}
267:  PASS
...

314:  github.com/carverauto/serviceradar/pkg/monitoring		coverage: 0.0% of statements
315:  ok  	github.com/carverauto/serviceradar/pkg/natsutil	2.752s	coverage: 0.1% of statements in ./...
316:  ok  	github.com/carverauto/serviceradar/pkg/poller	2.834s	coverage: 1.0% of statements in ./...
317:  ok  	github.com/carverauto/serviceradar/pkg/registry	3.438s	coverage: 5.6% of statements in ./...
318:  ok  	github.com/carverauto/serviceradar/pkg/scan	2.379s	coverage: 0.2% of statements in ./...
319:  ok  	github.com/carverauto/serviceradar/pkg/search	2.327s	coverage: 0.2% of statements in ./...
320:  github.com/carverauto/serviceradar/pkg/spireadmin		coverage: 0.0% of statements
321:  github.com/carverauto/serviceradar/pkg/swagger		coverage: 0.0% of statements
322:  ok  	github.com/carverauto/serviceradar/pkg/sweeper	2.706s	coverage: 2.4% of statements in ./...
323:  ok  	github.com/carverauto/serviceradar/pkg/sync	2.911s	coverage: 1.3% of statements in ./...
324:  ok  	github.com/carverauto/serviceradar/pkg/sync/integrations/armis	2.618s	coverage: 1.4% of statements in ./...
325:  ok  	github.com/carverauto/serviceradar/pkg/sync/integrations/netbox	2.077s	coverage: 0.4% of statements in ./...
326:  github.com/carverauto/serviceradar/pkg/version		coverage: 0.0% of statements
327:  github.com/carverauto/serviceradar/proto		coverage: 0.0% of statements
328:  FAIL
329:  ##[error]Process completed with exit code 1.
330:  Post job cleanup.

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2110#issuecomment-3644845553 Original created: 2025-12-12T04:21:09Z --- ## CI Feedback 🧐 A test triggered by this PR failed. Here is an AI-generated analysis of the failure: <table><tr><td> **Action:** test-go</td></tr> <tr><td> **Failed stage:** [Run Go Tests](https://github.com/carverauto/serviceradar/actions/runs/20155978525/job/57858590757) [❌] </td></tr> <tr><td> **Failure summary:** The action failed because <code>go test ./...</code> exited with a non-zero status (<code>FAIL</code>). While many packages reported <code>ok</code>, the overall run ended with <code>FAIL</code> at line 328 and the workflow exited with code 1. - Repeated errors indicate the tests attempted to read a configuration file at <code>/etc/serviceradar/core.json</code> and failed with <code>open /etc/serviceradar/core.json: no such file or </code> <code>directory</code> (lines 256–267, 264–266). This likely caused one or more tests to fail or the suite to consider the run unsuccessful. - No explicit failing test name or stack trace is shown in the provided snippet, but the missing config file appears to be the root cause during tests. </td></tr> <tr><td> <details><summary>Relevant error logs:</summary> ```yaml 1: Runner name: 'arc-runner-set-2tp2m-runner-l5lhq' 2: Runner group name: 'Default' ... 241: github.com/carverauto/serviceradar/cmd/mapper coverage: 0.0% of statements 242: github.com/carverauto/serviceradar/cmd/poller coverage: 0.0% of statements 243: github.com/carverauto/serviceradar/cmd/sync coverage: 0.0% of statements 244: github.com/carverauto/serviceradar/cmd/tools/cnpg-migrate coverage: 0.0% of statements 245: github.com/carverauto/serviceradar/cmd/tools/config-sync coverage: 0.0% of statements 246: github.com/carverauto/serviceradar/cmd/tools/kv-sweep coverage: 0.0% of statements 247: github.com/carverauto/serviceradar/cmd/tools/waitforport coverage: 0.0% of statements 248: github.com/carverauto/serviceradar/internal/fastsum coverage: 0.0% of statements 249: ok github.com/carverauto/serviceradar/pkg/agent 3.393s coverage: 1.3% of statements in ./... 250: github.com/carverauto/serviceradar/pkg/checker coverage: 0.0% of statements 251: github.com/carverauto/serviceradar/pkg/checker/dusk coverage: 0.0% of statements 252: ok github.com/carverauto/serviceradar/pkg/checker/snmp 2.855s coverage: 0.6% of statements in ./... 253: ok github.com/carverauto/serviceradar/pkg/checker/sysmonosx 2.717s coverage: 0.3% of statements in ./... 254: github.com/carverauto/serviceradar/pkg/cli coverage: 0.0% of statements 255: -test.shuffle 1765513246221280598 256: {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:46Z","message":"Failed to read configuration file"} 257: {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:46Z","message":"Failed to read configuration file"} 258: {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:47Z","message":"Failed to read configuration file"} 259: {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:47Z","message":"Failed to read configuration file"} 260: {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:48Z","message":"Failed to read configuration file"} 261: {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:48Z","message":"Failed to read configuration file"} 262: {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:49Z","message":"Failed to read configuration file"} 263: coverage: 1.7% of statements in ./... 264: {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:49Z","message":"Failed to read configuration file"} 265: {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:49Z","message":"Failed to read configuration file"} 266: {"level":"error","path":"/etc/serviceradar/core.json","error":"open /etc/serviceradar/core.json: no such file or directory","time":"2025-12-12T04:20:50Z","message":"Failed to read configuration file"} 267: PASS ... 314: github.com/carverauto/serviceradar/pkg/monitoring coverage: 0.0% of statements 315: ok github.com/carverauto/serviceradar/pkg/natsutil 2.752s coverage: 0.1% of statements in ./... 316: ok github.com/carverauto/serviceradar/pkg/poller 2.834s coverage: 1.0% of statements in ./... 317: ok github.com/carverauto/serviceradar/pkg/registry 3.438s coverage: 5.6% of statements in ./... 318: ok github.com/carverauto/serviceradar/pkg/scan 2.379s coverage: 0.2% of statements in ./... 319: ok github.com/carverauto/serviceradar/pkg/search 2.327s coverage: 0.2% of statements in ./... 320: github.com/carverauto/serviceradar/pkg/spireadmin coverage: 0.0% of statements 321: github.com/carverauto/serviceradar/pkg/swagger coverage: 0.0% of statements 322: ok github.com/carverauto/serviceradar/pkg/sweeper 2.706s coverage: 2.4% of statements in ./... 323: ok github.com/carverauto/serviceradar/pkg/sync 2.911s coverage: 1.3% of statements in ./... 324: ok github.com/carverauto/serviceradar/pkg/sync/integrations/armis 2.618s coverage: 1.4% of statements in ./... 325: ok github.com/carverauto/serviceradar/pkg/sync/integrations/netbox 2.077s coverage: 0.4% of statements in ./... 326: github.com/carverauto/serviceradar/pkg/version coverage: 0.0% of statements 327: github.com/carverauto/serviceradar/proto coverage: 0.0% of statements 328: FAIL 329: ##[error]Process completed with exit code 1. 330: Post job cleanup. ``` </details></td></tr></table>