cleanup, removed unused xls export stuff #2523

Merged

mfreeman451 merged 1 commit from refs/pull/2523/head into main

2025-12-08 05:01:21 +00:00

mfreeman451 commented

2025-12-08 04:58:29 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2079
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2079
Original created: 2025-12-08T04:58:29Z
Original updated: 2025-12-08T05:01:23Z
Original head: carverauto/serviceradar:chore/update_xlsx
Original base: main
Original merged: 2025-12-08T05:01:21Z by @mfreeman451

User description

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

PR Type

Enhancement

Description

Removed unused XLSX export functionality and dependency
Deleted ExportButton component that was no longer needed
Cleaned up build configuration files to remove xlsx references
Removed xlsx from package dependencies and lock file

Diagram Walkthrough

flowchart LR
  A["XLSX Dependency"] -->|removed| B["package.json"]
  C["ExportButton Component"] -->|deleted| D["web/src/components"]
  E["Build Config"] -->|cleaned| F["MODULE.bazel & web/BUILD.bazel"]
  B --> G["pnpm-lock.yaml"]
  D --> H["NetworkSweepView.jsx"]

File Walkthrough

Relevant files

Configuration changes

MODULE.bazel `Remove xlsx npm package reference` MODULE.bazel Removed `npm__xlsx__0.18.5__links` from the use_repo dependencies list	+0/-1
BUILD.bazel `Remove xlsx from build dependencies` web/BUILD.bazel Removed xlsx npm package load statement and npm_link_xlsx_store definition Removed `:node_modules/xlsx` dependency from three build targets (ts_project, js_binary, nextjs_standalone_build)	+0/-12

Dependencies

package.json `Remove xlsx from npm dependencies` web/package.json Removed `"xlsx": "^0.18.5"` from dependencies object	+1/-2
pnpm-lock.yaml `Remove xlsx and transitive dependencies` web/pnpm-lock.yaml Removed xlsx package entry and version specification Removed dependent packages: adler-32, cfb, codepage, crc-32, frac, ssf, wmf, word	+0/-72

Enhancement

NetworkSweepView.jsx `Remove ExportButton usage from component` web/src/components/Network/NetworkSweepView.jsx Removed import statement for ExportButton component Removed ExportButton component usage from both desktop and mobile UI sections	+0/-8
ExportButton.jsx `Delete unused ExportButton component` web/src/components/Utils/ExportButton.jsx Deleted entire file containing XLSX export functionality Removed 154 lines of code that handled network sweep data export to Excel format	+0/-154

Imported from GitHub pull request. Original GitHub pull request: #2079 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2079 Original created: 2025-12-08T04:58:29Z Original updated: 2025-12-08T05:01:23Z Original head: carverauto/serviceradar:chore/update_xlsx Original base: main Original merged: 2025-12-08T05:01:21Z by @mfreeman451 --- ### **User description** ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test? ___ ### **PR Type** Enhancement ___ ### **Description** - Removed unused XLSX export functionality and dependency - Deleted ExportButton component that was no longer needed - Cleaned up build configuration files to remove xlsx references - Removed xlsx from package dependencies and lock file ___ ### Diagram Walkthrough ```mermaid flowchart LR A["XLSX Dependency"] -->|removed| B["package.json"] C["ExportButton Component"] -->|deleted| D["web/src/components"] E["Build Config"] -->|cleaned| F["MODULE.bazel & web/BUILD.bazel"] B --> G["pnpm-lock.yaml"] D --> H["NetworkSweepView.jsx"] ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Configuration changes</strong></td><td><table> <tr> <td> <details> <summary><strong>MODULE.bazel</strong><dd><code>Remove xlsx npm package reference</code>                                                </dd></summary> <hr> MODULE.bazel <ul><li>Removed <code>npm__xlsx__0.18.5__links</code> from the use_repo dependencies list</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2079/files#diff-6136fc12446089c3db7360e923203dd114b6a1466252e71667c6791c20fe6bdc">+0/-1</a>      </td> </tr> <tr> <td> <details> <summary><strong>BUILD.bazel</strong><dd><code>Remove xlsx from build dependencies</code>                                            </dd></summary> <hr> web/BUILD.bazel <ul><li>Removed xlsx npm package load statement and npm_link_xlsx_store <br>definition<br> <li> Removed <code>:node_modules/xlsx</code> dependency from three build targets <br>(ts_project, js_binary, nextjs_standalone_build)</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2079/files#diff-1d59088f07bd1569a5a928ec3d13f6a85f7277c23483e5b7fa05a12d5fcaa394">+0/-12</a>    </td> </tr> </table></td></tr><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>package.json</strong><dd><code>Remove xlsx from npm dependencies</code>                                                </dd></summary> <hr> web/package.json - Removed `"xlsx": "^0.18.5"` from dependencies object </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2079/files#diff-b861012a5dd72b8a9f3281b7cf09f5a779c98569d040b1bbc1db50f1b15e7cce">+1/-2</a>      </td> </tr> <tr> <td> <details> <summary><strong>pnpm-lock.yaml</strong><dd><code>Remove xlsx and transitive dependencies</code>                                    </dd></summary> <hr> web/pnpm-lock.yaml <ul><li>Removed xlsx package entry and version specification<br> <li> Removed dependent packages: adler-32, cfb, codepage, crc-32, frac, <br>ssf, wmf, word</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2079/files#diff-f11bfba22b3604b3a7b52e44e10f4eae265b030b5682714833ba689eda12a27b">+0/-72</a>    </td> </tr> </table></td></tr><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>NetworkSweepView.jsx</strong><dd><code>Remove ExportButton usage from component</code>                                  </dd></summary> <hr> web/src/components/Network/NetworkSweepView.jsx <ul><li>Removed import statement for ExportButton component<br> <li> Removed ExportButton component usage from both desktop and mobile UI <br>sections</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2079/files#diff-38d2efe119c20a969f960b3e606517a504138f98163485a0eea8d801d1549a1f">+0/-8</a>      </td> </tr> <tr> <td> <details> <summary><strong>ExportButton.jsx</strong><dd><code>Delete unused ExportButton component</code>                                          </dd></summary> <hr> web/src/components/Utils/ExportButton.jsx <ul><li>Deleted entire file containing XLSX export functionality<br> <li> Removed 154 lines of code that handled network sweep data export to <br>Excel format</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2079/files#diff-48b7e0ea43506c8014956e76ff69387efd7f83dbc617fab1358f3e38c241d003">+0/-154</a>  </td> </tr> </table></td></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2025-12-08 04:59:04 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2079#issuecomment-3624780612
Original created: 2025-12-08T04:59:04Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Audit Logging: The PR removes an export feature and related UI without adding or referencing audit logs for this critical user action, but full logging might exist elsewhere not shown in the diff. Referred Code viewMode === 'hosts' ? 'bg-blue-500 text-white' : 'bg-gray-100 dark:bg-gray-700 text-gray-800 dark:text-gray-200' }`} > Host Details </button> </div> </div> </div> {/* Network Information Panel (Collapsible) */} {showNetworkInfo && ( <div className="bg-blue-50 dark:bg-blue-900/30 p-4 rounded-lg mb-4 relative"> <button onClick={() => setShowNetworkInfo(false)} className="absolute top-2 right-2 text-gray-500 hover:text-gray-700 dark:text-gray-400 dark:hover:text-gray-200" > <X size={16} /> </button> ... (clipped 77 lines) Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2079#issuecomment-3624780612 Original created: 2025-12-08T04:59:04Z --- ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR:<br> <table><tbody><tr><td colspan='2'><strong>Security Compliance</strong></td></tr> <tr><td>🟢</td><td><details><summary><strong>No security concerns identified</strong></summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'><strong>Ticket Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary>🎫 <strong>No ticket provided </strong></summary> - [ ] Create ticket/issue  </details></td></tr> <tr><td colspan='2'><strong>Codebase Duplication Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary><strong>Codebase context is not defined </strong></summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'><strong>Custom Compliance</strong></td></tr> <tr><td rowspan=5>🟢</td><td> <details><summary><strong>Generic: Meaningful Naming and Self-Documenting Code</strong></summary><br> **Objective:** Ensure all identifiers clearly express their purpose and intent, making code <br>self-documenting<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Robust Error Handling and Edge Case Management</strong></summary><br> **Objective:** Ensure comprehensive error handling that provides meaningful context and graceful <br>degradation<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Secure Error Handling</strong></summary><br> **Objective:** To prevent the leakage of sensitive system information through error messages while <br>providing sufficient detail for internal debugging.<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Secure Logging Practices</strong></summary><br> **Objective:** To ensure logs are useful for debugging and auditing without exposing sensitive <br>information like PII, PHI, or cardholder data.<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Security-First Input Validation and Data Handling</strong></summary><br> **Objective:** Ensure all data inputs are validated, sanitized, and handled securely to prevent <br>vulnerabilities<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td rowspan=1>⚪</td> <td><details> <summary><strong>Generic: Comprehensive Audit Trails</strong></summary><br> **Objective:** To create a detailed and reliable record of critical system actions for security analysis <br>and compliance.<br> **Status:** <br><a href='https://github.com/carverauto/serviceradar/pull/2079/files#diff-38d2efe119c20a969f960b3e606517a504138f98163485a0eea8d801d1549a1fR292-R389'><strong>Audit Logging</strong></a>: The PR removes an export feature and related UI without adding or referencing audit logs <br>for this critical user action, but full logging might exist elsewhere not shown in the <br>diff.<br> <details open><summary>Referred Code</summary> ```jsx viewMode === 'hosts' ? 'bg-blue-500 text-white' : 'bg-gray-100 dark:bg-gray-700 text-gray-800 dark:text-gray-200' }`} > Host Details </button> </div> </div> </div> {/* Network Information Panel (Collapsible) */} {showNetworkInfo && ( <div className="bg-blue-50 dark:bg-blue-900/30 p-4 rounded-lg mb-4 relative"> <button onClick={() => setShowNetworkInfo(false)} className="absolute top-2 right-2 text-gray-500 hover:text-gray-700 dark:text-gray-400 dark:hover:text-gray-200" > <X size={16} /> </button> ... (clipped 77 lines) ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td align="center" colspan="2">   </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant<br> 🟡 - Partial Compliant<br> 🔴 - Not Compliant<br> ⚪ - Requires Further Human Verification<br> 🏷️ - Compliance label<br> </details>

qodo-code-review[bot] commented

2025-12-08 04:59:20 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2079#issuecomment-3624783098
Original created: 2025-12-08T04:59:20Z

PR Code Suggestions ✨

No code suggestions found for the PR.

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2079#issuecomment-3624783098 Original created: 2025-12-08T04:59:20Z --- ## PR Code Suggestions ✨ No code suggestions found for the PR.