cleanup #2522

Merged

mfreeman451 merged 2 commits from refs/pull/2522/head into main

2025-12-08 04:48:08 +00:00

mfreeman451 commented

2025-12-08 04:36:55 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2078
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2078
Original created: 2025-12-08T04:36:55Z
Original updated: 2025-12-08T04:48:11Z
Original head: carverauto/serviceradar:chore/eslintrc-upgrade
Original base: main
Original merged: 2025-12-08T04:48:08Z by @mfreeman451

User description

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

PR Type

Enhancement

Description

Remove unused @eslint/eslintrc dependency from project
Clean up package.json and lock file entries

Diagram Walkthrough

flowchart LR
  A["package.json"] -- "remove @eslint/eslintrc" --> B["Updated dependencies"]
  C["pnpm-lock.yaml"] -- "remove version entry" --> B

File Walkthrough

Relevant files

Dependencies

package.json `Remove @eslint/eslintrc devDependency` web/package.json Removed `@eslint/eslintrc` from devDependencies Cleaned up unused ESLint configuration dependency	+0/-1
pnpm-lock.yaml `Remove @eslint/eslintrc lock entry` web/pnpm-lock.yaml Removed `@eslint/eslintrc` version 3.3.1 entry Updated lock file to reflect dependency removal	+0/-3

Imported from GitHub pull request. Original GitHub pull request: #2078 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2078 Original created: 2025-12-08T04:36:55Z Original updated: 2025-12-08T04:48:11Z Original head: carverauto/serviceradar:chore/eslintrc-upgrade Original base: main Original merged: 2025-12-08T04:48:08Z by @mfreeman451 --- ### **User description** ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test? ___ ### **PR Type** Enhancement ___ ### **Description** - Remove unused `@eslint/eslintrc` dependency from project - Clean up package.json and lock file entries ___ ### Diagram Walkthrough ```mermaid flowchart LR A["package.json"] -- "remove @eslint/eslintrc" --> B["Updated dependencies"] C["pnpm-lock.yaml"] -- "remove version entry" --> B ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td>Dependencies</td><td><table> <tr> <td> <details> <summary>package.json<dd><code>Remove @eslint/eslintrc devDependency</code>                                        </dd></summary> <hr> web/package.json <ul><li>Removed <code>@eslint/eslintrc</code> from devDependencies <li> Cleaned up unused ESLint configuration dependency</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2078/files#diff-b861012a5dd72b8a9f3281b7cf09f5a779c98569d040b1bbc1db50f1b15e7cce">+0/-1</a>      </td> </tr> <tr> <td> <details> <summary>pnpm-lock.yaml<dd><code>Remove @eslint/eslintrc lock entry</code>                                              </dd></summary> <hr> web/pnpm-lock.yaml <ul><li>Removed <code>@eslint/eslintrc</code> version 3.3.1 entry <li> Updated lock file to reflect dependency removal</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2078/files#diff-f11bfba22b3604b3a7b52e44e10f4eae265b030b5682714833ba689eda12a27b">+0/-3</a>      </td> </tr> </table></td></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2025-12-08 04:37:16 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2078#issuecomment-3624693393
Original created: 2025-12-08T04:37:16Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: No audit scope: The PR only updates dependencies and lockfile without adding or modifying runtime code, so it neither demonstrates nor violates audit logging requirements within the shown diff. Referred Code `"knip": "^5.57.2", "lodash": "^4.17.21", "lodash.set": "^4.3.2", "lucide-react": "^0.476.0", "next": "16.0.7", "next-runtime-env": "^3.3.0", "react": "19.2.1", "react-dom": "19.2.1", "reactflow": "^11.11.4", "recharts": "^2.15.1", "styled-jsx": "^5.1.6", "use-debounce": "^10.0.5", "xlsx": "^0.18.5" }, "devDependencies": { "@tailwindcss/postcss": "^4.1.17", "tailwindcss-animate": "^1.0.7", "@types/d3-hierarchy": "^3.1.7", "@types/dagre": "^0.7.52",` Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: No identifiers added: The diff contains only dependency list changes and adds no new identifiers or code to assess for naming clarity. Referred Code `"knip": "^5.57.2", "lodash": "^4.17.21", "lodash.set": "^4.3.2", "lucide-react": "^0.476.0", "next": "16.0.7", "next-runtime-env": "^3.3.0", "react": "19.2.1", "react-dom": "19.2.1", "reactflow": "^11.11.4", "recharts": "^2.15.1", "styled-jsx": "^5.1.6", "use-debounce": "^10.0.5", "xlsx": "^0.18.5" }, "devDependencies": { "@tailwindcss/postcss": "^4.1.17", "tailwindcss-animate": "^1.0.7", "@types/d3-hierarchy": "^3.1.7", "@types/dagre": "^0.7.52",` Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: No error paths: The PR modifies dependency metadata only and introduces no executable code where error handling could be evaluated. Referred Code `"knip": "^5.57.2", "lodash": "^4.17.21", "lodash.set": "^4.3.2", "lucide-react": "^0.476.0", "next": "16.0.7", "next-runtime-env": "^3.3.0", "react": "19.2.1", "react-dom": "19.2.1", "reactflow": "^11.11.4", "recharts": "^2.15.1", "styled-jsx": "^5.1.6", "use-debounce": "^10.0.5", "xlsx": "^0.18.5" }, "devDependencies": { "@tailwindcss/postcss": "^4.1.17", "tailwindcss-animate": "^1.0.7", "@types/d3-hierarchy": "^3.1.7", "@types/dagre": "^0.7.52",` Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: No user errors: There are no user-facing error messages or error handling changes in the dependency cleanup diff to assess for secure messaging. Referred Code `"knip": "^5.57.2", "lodash": "^4.17.21", "lodash.set": "^4.3.2", "lucide-react": "^0.476.0", "next": "16.0.7", "next-runtime-env": "^3.3.0", "react": "19.2.1", "react-dom": "19.2.1", "reactflow": "^11.11.4", "recharts": "^2.15.1", "styled-jsx": "^5.1.6", "use-debounce": "^10.0.5", "xlsx": "^0.18.5" }, "devDependencies": { "@tailwindcss/postcss": "^4.1.17", "tailwindcss-animate": "^1.0.7", "@types/d3-hierarchy": "^3.1.7", "@types/dagre": "^0.7.52",` Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: No logging changes: The changes only remove a devDependency and its lock entries, adding no logging statements to evaluate for sensitivity or structure. Referred Code `version: 5.1.7(@babel/core@7.28.5)(react@19.2.1) use-debounce: specifier: ^10.0.5 version: 10.0.5(react@19.2.1) xlsx: specifier: ^0.18.5 version: 0.18.5 devDependencies: '@tailwindcss/postcss': specifier: ^4.1.17 version: 4.1.17 '@types/d3-hierarchy': specifier: ^3.1.7` Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: No input handling: No new input processing or security-relevant code was added in this PR; only dependency entries were modified. Referred Code `"knip": "^5.57.2", "lodash": "^4.17.21", "lodash.set": "^4.3.2", "lucide-react": "^0.476.0", "next": "16.0.7", "next-runtime-env": "^3.3.0", "react": "19.2.1", "react-dom": "19.2.1", "reactflow": "^11.11.4", "recharts": "^2.15.1", "styled-jsx": "^5.1.6", "use-debounce": "^10.0.5", "xlsx": "^0.18.5" }, "devDependencies": { "@tailwindcss/postcss": "^4.1.17", "tailwindcss-animate": "^1.0.7", "@types/d3-hierarchy": "^3.1.7", "@types/dagre": "^0.7.52",` Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2078#issuecomment-3624693393 Original created: 2025-12-08T04:37:16Z --- ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR: <table><tbody><tr><td colspan='2'>Security Compliance</td></tr> <tr><td>🟢</td><td><details><summary>No security concerns identified</summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'>Ticket Compliance</td></tr> <tr><td>⚪</td><td><details><summary>🎫 No ticket provided </summary> - [ ] Create ticket/issue  </details></td></tr> <tr><td colspan='2'>Codebase Duplication Compliance</td></tr> <tr><td>⚪</td><td><details><summary>Codebase context is not defined </summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'>Custom Compliance</td></tr> <tr><td rowspan=6>⚪</td> <td><details> <summary>Generic: Comprehensive Audit Trails</summary> **Objective:** To create a detailed and reliable record of critical system actions for security analysis and compliance. **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2078/files#diff-b861012a5dd72b8a9f3281b7cf09f5a779c98569d040b1bbc1db50f1b15e7cceR17-R35'>No audit scope</a>: The PR only updates dependencies and lockfile without adding or modifying runtime code, so it neither demonstrates nor violates audit logging requirements within the shown diff. <details open><summary>Referred Code</summary> ```json "knip": "^5.57.2", "lodash": "^4.17.21", "lodash.set": "^4.3.2", "lucide-react": "^0.476.0", "next": "16.0.7", "next-runtime-env": "^3.3.0", "react": "19.2.1", "react-dom": "19.2.1", "reactflow": "^11.11.4", "recharts": "^2.15.1", "styled-jsx": "^5.1.6", "use-debounce": "^10.0.5", "xlsx": "^0.18.5" }, "devDependencies": { "@tailwindcss/postcss": "^4.1.17", "tailwindcss-animate": "^1.0.7", "@types/d3-hierarchy": "^3.1.7", "@types/dagre": "^0.7.52", ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Meaningful Naming and Self-Documenting Code</summary> **Objective:** Ensure all identifiers clearly express their purpose and intent, making code self-documenting **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2078/files#diff-b861012a5dd72b8a9f3281b7cf09f5a779c98569d040b1bbc1db50f1b15e7cceR17-R35'>No identifiers added</a>: The diff contains only dependency list changes and adds no new identifiers or code to assess for naming clarity. <details open><summary>Referred Code</summary> ```json "knip": "^5.57.2", "lodash": "^4.17.21", "lodash.set": "^4.3.2", "lucide-react": "^0.476.0", "next": "16.0.7", "next-runtime-env": "^3.3.0", "react": "19.2.1", "react-dom": "19.2.1", "reactflow": "^11.11.4", "recharts": "^2.15.1", "styled-jsx": "^5.1.6", "use-debounce": "^10.0.5", "xlsx": "^0.18.5" }, "devDependencies": { "@tailwindcss/postcss": "^4.1.17", "tailwindcss-animate": "^1.0.7", "@types/d3-hierarchy": "^3.1.7", "@types/dagre": "^0.7.52", ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Robust Error Handling and Edge Case Management</summary> **Objective:** Ensure comprehensive error handling that provides meaningful context and graceful degradation **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2078/files#diff-b861012a5dd72b8a9f3281b7cf09f5a779c98569d040b1bbc1db50f1b15e7cceR17-R35'>No error paths</a>: The PR modifies dependency metadata only and introduces no executable code where error handling could be evaluated. <details open><summary>Referred Code</summary> ```json "knip": "^5.57.2", "lodash": "^4.17.21", "lodash.set": "^4.3.2", "lucide-react": "^0.476.0", "next": "16.0.7", "next-runtime-env": "^3.3.0", "react": "19.2.1", "react-dom": "19.2.1", "reactflow": "^11.11.4", "recharts": "^2.15.1", "styled-jsx": "^5.1.6", "use-debounce": "^10.0.5", "xlsx": "^0.18.5" }, "devDependencies": { "@tailwindcss/postcss": "^4.1.17", "tailwindcss-animate": "^1.0.7", "@types/d3-hierarchy": "^3.1.7", "@types/dagre": "^0.7.52", ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Secure Error Handling</summary> **Objective:** To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2078/files#diff-b861012a5dd72b8a9f3281b7cf09f5a779c98569d040b1bbc1db50f1b15e7cceR17-R35'>No user errors</a>: There are no user-facing error messages or error handling changes in the dependency cleanup diff to assess for secure messaging. <details open><summary>Referred Code</summary> ```json "knip": "^5.57.2", "lodash": "^4.17.21", "lodash.set": "^4.3.2", "lucide-react": "^0.476.0", "next": "16.0.7", "next-runtime-env": "^3.3.0", "react": "19.2.1", "react-dom": "19.2.1", "reactflow": "^11.11.4", "recharts": "^2.15.1", "styled-jsx": "^5.1.6", "use-debounce": "^10.0.5", "xlsx": "^0.18.5" }, "devDependencies": { "@tailwindcss/postcss": "^4.1.17", "tailwindcss-animate": "^1.0.7", "@types/d3-hierarchy": "^3.1.7", "@types/dagre": "^0.7.52", ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Secure Logging Practices</summary> **Objective:** To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2078/files#diff-f11bfba22b3604b3a7b52e44e10f4eae265b030b5682714833ba689eda12a27bR58-R70'>No logging changes</a>: The changes only remove a devDependency and its lock entries, adding no logging statements to evaluate for sensitivity or structure. <details open><summary>Referred Code</summary> ```yaml version: 5.1.7(@babel/core@7.28.5)(react@19.2.1) use-debounce: specifier: ^10.0.5 version: 10.0.5(react@19.2.1) xlsx: specifier: ^0.18.5 version: 0.18.5 devDependencies: '@tailwindcss/postcss': specifier: ^4.1.17 version: 4.1.17 '@types/d3-hierarchy': specifier: ^3.1.7 ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Security-First Input Validation and Data Handling</summary> **Objective:** Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2078/files#diff-b861012a5dd72b8a9f3281b7cf09f5a779c98569d040b1bbc1db50f1b15e7cceR17-R35'>No input handling</a>: No new input processing or security-relevant code was added in this PR; only dependency entries were modified. <details open><summary>Referred Code</summary> ```json "knip": "^5.57.2", "lodash": "^4.17.21", "lodash.set": "^4.3.2", "lucide-react": "^0.476.0", "next": "16.0.7", "next-runtime-env": "^3.3.0", "react": "19.2.1", "react-dom": "19.2.1", "reactflow": "^11.11.4", "recharts": "^2.15.1", "styled-jsx": "^5.1.6", "use-debounce": "^10.0.5", "xlsx": "^0.18.5" }, "devDependencies": { "@tailwindcss/postcss": "^4.1.17", "tailwindcss-animate": "^1.0.7", "@types/d3-hierarchy": "^3.1.7", "@types/dagre": "^0.7.52", ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td align="center" colspan="2"> - [ ] Update  </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant 🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label </details>

qodo-code-review[bot] commented

2025-12-08 04:37:31 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2078#issuecomment-3624693863
Original created: 2025-12-08T04:37:31Z

PR Code Suggestions ✨

No code suggestions found for the PR.

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2078#issuecomment-3624693863 Original created: 2025-12-08T04:37:31Z --- ## PR Code Suggestions ✨ No code suggestions found for the PR.