pkg/agent/sweep_service.go cleanup #25

New issue

Closed

opened 2026-03-28 04:16:04 +00:00 by mfreeman451 · 0 comments

mfreeman451 commented

2026-03-28 04:16:04 +00:00

Owner

Imported from GitHub.

Original GitHub issue: #62
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/62
Original created: 2025-01-20T03:23:17Z

The SweepService type is defined in pkg/agent/sweep_service.go, but it uses types and functions from pkg/sweeper. This creates a circular dependency. This should be refactored to avoid the circular dependency.

Cleanup SweepServicce type definition
improve error handling in performSweep()
leverage identifyService()
GetStatus() should return an error
The logic in applyDefaultConfig() could be moved to NewSweepService()

Imported from GitHub. Original GitHub issue: #62 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/62 Original created: 2025-01-20T03:23:17Z --- The SweepService type is defined in pkg/agent/sweep_service.go, but it uses types and functions from pkg/sweeper. This creates a circular dependency. This should be refactored to avoid the circular dependency. - [ ] Cleanup SweepServicce type definition - [ ] improve error handling in performSweep() - [ ] leverage identifyService() - [ ] GetStatus() should return an error - [ ] The logic in applyDefaultConfig() could be moved to NewSweepService()

Rows
Columns