increase from 5g to 100g for cnpg #2471
No reviewers
Labels
No labels
1week
2weeks
Failed compliance check
IP cameras
NATS
Possible security concern
Review effort 1/5
Review effort 2/5
Review effort 3/5
Review effort 4/5
Review effort 5/5
UI
aardvark
accessibility
amd64
api
arm64
auth
back-end
bgp
blog
bug
build
checkers
ci-cd
cleanup
cnpg
codex
core
dependencies
device-management
documentation
duplicate
dusk
ebpf
enhancement
eta 1d
eta 1hr
eta 3d
eta 3hr
feature
fieldsurvey
github_actions
go
good first issue
help wanted
invalid
javascript
k8s
log-collector
mapper
mtr
needs-triage
netflow
network-sweep
observability
oracle
otel
plug-in
proton
python
question
reddit
redhat
research
rperf
rperf-checker
rust
sdk
security
serviceradar-agent
serviceradar-agent-gateway
serviceradar-web
serviceradar-web-ng
siem
snmp
sysmon
topology
ubiquiti
wasm
wontfix
zen-engine
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
carverauto/serviceradar!2471
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refs/pull/2471/head"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Imported from GitHub pull request.
Original GitHub pull request: #2005
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2005
Original created: 2025-11-24T15:13:34Z
Original updated: 2025-11-24T15:17:15Z
Original head: carverauto/serviceradar:2003-chorek8shelm-increase-size-for-cnpg
Original base: main
Original merged: 2025-11-24T15:17:11Z by @mfreeman451
User description
IMPORTANT: Please sign the Developer Certificate of Origin
Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:
Describe your changes
Issue ticket number and link
Code checklist before requesting a review
PR Type
Enhancement
Description
Increase CNPG PostgreSQL storage from 5Gi to 100Gi
Updates default storage size across Helm templates
Updates base Kubernetes deployment configuration
Updates documentation to reflect new storage allocation
Diagram Walkthrough
File Walkthrough
values.yaml
Update default CNPG storage size to 100Gihelm/serviceradar/values.yaml
storageSizeparameter in postgres configurationspire-postgres.yaml
Update Helm template storage default to 100Gihelm/serviceradar/templates/spire-postgres.yaml
cnpg-cluster.yaml
Update base K8s CNPG storage to 100Gik8s/demo/base/spire/cnpg-cluster.yaml
DEPLOYMENT.md
Update documentation for new storage sizek8s/demo/DEPLOYMENT.md
Imported GitHub PR comment.
Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2005#issuecomment-3571282655
Original created: 2025-11-24T15:14:01Z
PR Compliance Guide 🔍
Below is a summary of compliance checks for this PR:
Resource overprovisioning
Description: Setting a default CNPG storage size to 100Gi may unintentionally provision large
persistent volumes across environments, potentially exceeding quotas or incurring
unexpected costs; consider scoping defaults per environment or documenting overrides.
values.yaml [183-183]
Referred Code
🎫 #2003
the demo namespace.
Codebase context is not defined
Follow the guide to enable codebase context checks.
Generic: Meaningful Naming and Self-Documenting Code
Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting
Status: Passed
Generic: Secure Logging Practices
Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.
Status: Passed
Generic: Comprehensive Audit Trails
Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.
Status:
Not Applicable Scope: The PR only updates storage size configuration and documentation without introducing code
paths related to auditable actions, so applicability of audit trail requirements cannot be
determined from this diff.
Referred Code
Generic: Robust Error Handling and Edge Case Management
Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation
Status:
No Error Paths: The changes are declarative config updates for storage size and do not introduce
executable logic where error handling would apply, so compliance cannot be assessed from
this diff.
Referred Code
Generic: Secure Error Handling
Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.
Status:
No User Errors: The PR alters storage documentation only and does not change user-facing error messages,
so secure error handling compliance cannot be evaluated from this diff.
Referred Code
Generic: Security-First Input Validation and Data Handling
Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities
Status:
Config Change Only: The update only increases the default storage size parameter and does not touch input
handling or data processing logic, so validation/security implications cannot be
determined from this diff.
Referred Code
Compliance status legend
🟢 - Fully Compliant🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label
Imported GitHub PR comment.
Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2005#issuecomment-3571289286
Original created: 2025-11-24T15:14:56Z
PR Code Suggestions ✨
Explore these optional code suggestions:
Reduce default storage for broader compatibility
Reduce the default
storageSizefrom100Gito a more moderate value like20Gitoprevent deployment failures in resource-constrained environments. Add a comment
guiding users to increase this for production.
helm/serviceradar/values.yaml [183]
Suggestion importance[1-10]: 8
__
Why: The suggestion correctly identifies that a 100Gi default storage size is excessive for development or testing environments and could cause deployment failures, proposing a more reasonable default to improve usability.
Imported GitHub PR comment.
Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2005#issuecomment-3571296793
Original created: 2025-11-24T15:16:00Z
CI Feedback 🧐
A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
Action: build
Failed stage: Test [❌]
Failure summary:
The action failed due to Bazel loading phase errors caused by failed external repository fetches:
-
Could not download
bison-3.8.2.tar.gzfromhttps://ftp.gnu.org/gnu/bison/bison-3.8.2.tar.gz: Connecttimed out.
- Errors reported at:
-
/external/bazel_tools/tools/build_defs/repo/http.bzl:155:45during fetch of repository
+_repo_rules3+bison_src-
third_party/pg_extension_toolchain/bison/BUILD.bazel:5:18which depends on@@+_repo_rules3+bison_src//:all_srcs- Could not download
gperf-3.1.tar.gzfromhttps://ftp.gnu.org/gnu/gperf/gperf-3.1.tar.gz: Connect timed out.- Errors reported at:
-
/external/bazel_tools/tools/build_defs/repo/http.bzl:155:45during fetch of repository+_repo_rules3+gperf_src-
third_party/pg_extension_toolchain/gperf/BUILD.bazel:5:18whichdepends on
@@+_repo_rules3+gperf_src//:all_srcs- These timeouts led to "no such package" errors for
@@+_repo_rules3+bison_src//and@@+repo_rules3+gperf_src//, causing multiple image-related targets(e.g.,
//docker/images:cnpg_image_amd64*) to fail analysis.- Bazel concluded: "command succeeded,
but there were loading phase errors" and "Build did NOT complete successfully", resulting in exit
code 1.
- Note: Tests themselves passed (executed 0 due to caching; reported "All tests passed but
there were other errors during the build"); the failure is due to repository fetch/network issues,
not test failures.
Relevant error logs: