carverauto/serviceradar

Fork 0

spiffe integration in k8s demo #2389

Merged

mfreeman451 merged 20 commits from refs/pull/2389/head into main

2025-10-27 06:37:40 +00:00

mfreeman451 commented

2025-10-25 23:54:40 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #1893
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1893
Original created: 2025-10-25T23:54:40Z
Original updated: 2025-10-27T06:37:43Z
Original head: carverauto/serviceradar:1892-stand-up-spiffespire-in-the-demo-kubernetes-namespace-migrate-a-representative-set-of-services-to-consume-spiffe-issued-identities-and-capture-operational-runbooks
Original base: main
Original merged: 2025-10-27T06:37:40Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #1893 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1893 Original created: 2025-10-25T23:54:40Z Original updated: 2025-10-27T06:37:43Z Original head: carverauto/serviceradar:1892-stand-up-spiffespire-in-the-demo-kubernetes-namespace-migrate-a-representative-set-of-services-to-consume-spiffe-issued-identities-and-capture-operational-runbooks Original base: main Original merged: 2025-10-27T06:37:40Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

mfreeman451 commented

2025-10-25 23:56:37 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131566
Original created: 2025-10-25T23:56:37Z
Original path: k8s/cnpg/00-create-creds.sh
Original line: 11

dont need this kratos garbage

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131566 Original created: 2025-10-25T23:56:37Z Original path: k8s/cnpg/00-create-creds.sh Original line: 11 --- dont need this kratos garbage

mfreeman451 commented

2025-10-25 23:56:50 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131593
Original created: 2025-10-25T23:56:50Z
Original path: k8s/cnpg/cnpg-auth.yaml
Original line: 9

hard coded password, needs to be changed

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131593 Original created: 2025-10-25T23:56:50Z Original path: k8s/cnpg/cnpg-auth.yaml Original line: 9 --- hard coded password, needs to be changed

mfreeman451 commented

2025-10-25 23:57:03 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131699
Original created: 2025-10-25T23:57:03Z
Original path: k8s/cnpg/cnpg-auth.yaml
Original line: 20

need to get rid of kratos garbage

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131699 Original created: 2025-10-25T23:57:03Z Original path: k8s/cnpg/cnpg-auth.yaml Original line: 20 --- need to get rid of kratos garbage

mfreeman451 commented

2025-10-25 23:57:18 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131763
Original created: 2025-10-25T23:57:18Z
Original path: k8s/cnpg/db-creds.yaml
Original line: 9

dont need eventrunner creds in here at all either

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131763 Original created: 2025-10-25T23:57:18Z Original path: k8s/cnpg/db-creds.yaml Original line: 9 --- dont need eventrunner creds in here at all either

mfreeman451 commented

2025-10-25 23:57:25 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131778
Original created: 2025-10-25T23:57:25Z
Original path: k8s/cnpg/exc.sql
Original line: 3

dont need any of this ory stuff

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131778 Original created: 2025-10-25T23:57:25Z Original path: k8s/cnpg/exc.sql Original line: 3 --- dont need any of this ory stuff

mfreeman451 commented

2025-10-25 23:57:36 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131827
Original created: 2025-10-25T23:57:36Z
Original path: k8s/cnpg/new-pg-cluster.yaml
Original line: 34

dont need any of this ory stuff

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131827 Original created: 2025-10-25T23:57:36Z Original path: k8s/cnpg/new-pg-cluster.yaml Original line: 34 --- dont need any of this ory stuff

CollabCheck-StockholmUni commented

2025-10-26 00:12:46 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @CollabCheck-StockholmUni
Original URL: https://github.com/carverauto/serviceradar/pull/1893#issuecomment-3447884414
Original created: 2025-10-26T00:12:46Z

Hi @mfreeman451, we're researchers from Stockholm University studying communication on GitHub.

A message you posted may come across as rude, disrespectful, or unreasonable — something that could discourage others from contributing or sharing their ideas:

dont need this kratos garbage

You can opt out of messages like this here.

If you are the moderator of this repository, you can opt out of messages like this for the entire repo here.

Note

Participate in our four-question survey to provide feedback, and follow us for project updates!

This message was flagged by an automated system and reviewed using an AI tool to check for tone and clarity concerns.

We’re not here to judge. Our goal is to help make collaboration smoother for everyone.

Messages like this can sometimes cause stress or burnout for others involved in the project.

Here are a few quick tips to make messages clearer and easier to engage with:

Rephrase strong or absolute language
Explain your reasoning, or suggest an alternative
Use tools like AI writing assistants to help reword or check tone

Thanks for contributing to GitHub and helping improve collaboration for everyone!

Imported GitHub PR comment. Original author: @CollabCheck-StockholmUni Original URL: https://github.com/carverauto/serviceradar/pull/1893#issuecomment-3447884414 Original created: 2025-10-26T00:12:46Z --- Hi @mfreeman451, we're researchers from Stockholm University studying communication on GitHub. A [message](https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463131566) you posted may come across as **rude, disrespectful, or unreasonable** — something that could discourage others from contributing or sharing their ideas: > dont need this kratos garbage You can opt out of messages like this [here](http://otree-extra-url-d0bb646a8437.herokuapp.com/?hash_id=3e8a9432d289150b08f16033934376a81e6fab07012b11ba8f38d59cff83514a&opt_out=own&source=github). **If you are the moderator of this repository, you can opt out of messages like this for the entire repo [here](http://otree-extra-url-d0bb646a8437.herokuapp.com/?hash_id=3e8a9432d289150b08f16033934376a81e6fab07012b11ba8f38d59cff83514a&opt_out=all&source=github).** >[!NOTE] >Participate in our [four-question survey](http://otree-extra-url-d0bb646a8437.herokuapp.com/?hash_id=3e8a9432d289150b08f16033934376a81e6fab07012b11ba8f38d59cff83514a&opt_out=none&source=github) to provide feedback, and [follow us](https://github.com/huentat/GitHub_Research) for project updates! --- This message was flagged by an automated system and reviewed using an AI tool to check for tone and clarity concerns. We’re not here to judge. Our goal is to help make collaboration smoother for everyone. Messages like this can sometimes cause stress or burnout for others involved in the project. Here are a few quick tips to make messages clearer and easier to engage with: - Rephrase strong or absolute language - Explain your reasoning, or suggest an alternative - Use tools like AI writing assistants to help reword or check tone Thanks for contributing to GitHub and helping improve collaboration for everyone!

mfreeman451 commented

2025-10-26 03:22:40 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463175843
Original created: 2025-10-26T03:22:40Z
Original path: docker/images/BUILD.bazel
Original line: 1264

is this necessary? seems dangerous

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2463175843 Original created: 2025-10-26T03:22:40Z Original path: docker/images/BUILD.bazel Original line: 1264 --- is this necessary? seems dangerous

mfreeman451 commented

2025-10-27 06:36:35 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2464569881
Original created: 2025-10-27T06:36:35Z
Original path: docker/images/BUILD.bazel
Original line: 1264

removed

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1893#discussion_r2464569881 Original created: 2025-10-27T06:36:35Z Original path: docker/images/BUILD.bazel Original line: 1264 --- removed