Apply preferred .bazelrc changes #2308

Merged

mfreeman451 merged 1 commit from refs/pull/2308/head into main

2025-10-12 18:21:39 +00:00

mfreeman451 commented

2025-10-12 18:18:21 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #1747
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1747
Original created: 2025-10-12T18:18:21Z
Original updated: 2025-10-12T18:21:42Z
Original head: carverauto/serviceradar:fix-bazelrc-preferred
Original base: main
Original merged: 2025-10-12T18:21:39Z by @mfreeman451

User description

….bazel.lock

PR Type

Enhancement, Bug fix

Description

Add no_remote configuration profile to disable remote execution and caching
Update darwin_pkg profile to use no_remote config and enable timestamps
Consolidate remote execution settings into reusable configuration

Diagram Walkthrough

flowchart LR
  A["New no_remote config"] --> B["Disables remote execution"]
  A --> C["Disables remote caching"]
  D["darwin_pkg profile"] --> E["Uses no_remote config"]
  D --> F["Enables PKG timestamps"]

File Walkthrough

Relevant files

Configuration changes

.bazelrc

Add no_remote config and refactor darwin_pkg profile

.bazelrc

Added no_remote configuration profile with flags to disable remote
execution, caching, and BES backend
Modified darwin_pkg profile to use no_remote config instead of
individual flags
Changed PKG_DISABLE_TIMESTAMP from 1 to 0 in darwin_pkg profile

+10/-4

Imported from GitHub pull request. Original GitHub pull request: #1747 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1747 Original created: 2025-10-12T18:18:21Z Original updated: 2025-10-12T18:21:42Z Original head: carverauto/serviceradar:fix-bazelrc-preferred Original base: main Original merged: 2025-10-12T18:21:39Z by @mfreeman451 --- ### **User description** ….bazel.lock ___ ### **PR Type** Enhancement, Bug fix ___ ### **Description** - Add `no_remote` configuration profile to disable remote execution and caching - Update `darwin_pkg` profile to use `no_remote` config and enable timestamps - Consolidate remote execution settings into reusable configuration ___ ### Diagram Walkthrough ```mermaid flowchart LR A["New no_remote config"] --> B["Disables remote execution"] A --> C["Disables remote caching"] D["darwin_pkg profile"] --> E["Uses no_remote config"] D --> F["Enables PKG timestamps"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Configuration changes</strong></td><td><table> <tr> <td> <details> <summary><strong>.bazelrc</strong><dd><code>Add no_remote config and refactor darwin_pkg profile</code>          </dd></summary> <hr> .bazelrc <ul><li>Added <code>no_remote</code> configuration profile with flags to disable remote <br>execution, caching, and BES backend<br> <li> Modified <code>darwin_pkg</code> profile to use <code>no_remote</code> config instead of <br>individual flags<br> <li> Changed <code>PKG_DISABLE_TIMESTAMP</code> from <code>1</code> to <code>0</code> in <code>darwin_pkg</code> profile</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/1747/files#diff-544556920c45b42cbfe40159b082ce8af6bd929e492d076769226265f215832f">+10/-4</a>    </td> </tr> </table></td></tr></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2025-10-12 18:18:40 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1747#issuecomment-3395185740
Original created: 2025-10-12T18:18:40Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
⚪	No custom compliance provided Follow the guide to enable custom compliance check.

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1747#issuecomment-3395185740 Original created: 2025-10-12T18:18:40Z --- ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR:<br> <table><tbody><tr><td colspan='2'><strong>Security Compliance</strong></td></tr> <tr><td>🟢</td><td><details><summary><strong>No security concerns identified</strong></summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'><strong>Ticket Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary>🎫 <strong>No ticket provided </summary></strong> - [ ] Create ticket/issue  </details></td></tr> <tr><td colspan='2'><strong>Codebase Duplication Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary><strong>Codebase context is not defined </strong></summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'><strong>Custom Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary><strong>No custom compliance provided</strong></summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/'>guide</a> to enable custom compliance check. </details></td></tr> <tr><td align="center" colspan="2">   </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant<br> 🟡 - Partial Compliant<br> 🔴 - Not Compliant<br> ⚪ - Requires Further Human Verification<br> 🏷️ - Compliance label<br> </details>

qodo-code-review[bot] commented

2025-10-12 18:19:25 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1747#issuecomment-3395187518
Original created: 2025-10-12T18:19:25Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Use modern flag or remove it Remove the redundant `--remote_download_minimal` flag, as it has no effect when remote execution is disabled in the `no_remote` configuration. .bazelrc [41] `-build:no_remote --remote_download_minimal +` Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies that the `--remote_download_minimal` flag is redundant since remote execution is disabled in the `no_remote` config, making the flag a no-op. Removing it simplifies the configuration.	Low
More

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1747#issuecomment-3395187518 Original created: 2025-10-12T18:19:25Z --- ## PR Code Suggestions ✨  Explore these optional code suggestions: <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion                                                                                                                                    </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=1>General</td> <td> <details><summary>Use modern flag or remove it</summary> ___ **Remove the redundant <code>--remote_download_minimal</code> flag, as it has no effect when <br>remote execution is disabled in the <code>no_remote</code> configuration.** [.bazelrc [41]](https://github.com/carverauto/serviceradar/pull/1747/files#diff-544556920c45b42cbfe40159b082ce8af6bd929e492d076769226265f215832fR41-R41) ```diff -build:no_remote --remote_download_minimal + ``` - [ ] **Apply / Chat**  <details><summary>Suggestion importance[1-10]: 5</summary> __ Why: The suggestion correctly identifies that the `--remote_download_minimal` flag is redundant since remote execution is disabled in the `no_remote` config, making the flag a no-op. Removing it simplifies the configuration. </details></details></td><td align=center>Low </td></tr> <tr><td align="center" colspan="2"> - [ ] More  </td><td></td></tr></tbody></table>