corrected workflow #2268

Merged

mfreeman451 merged 1 commit from refs/pull/2268/head into main

2025-10-04 04:56:52 +00:00

mfreeman451 commented

2025-10-04 04:54:39 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #1694
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1694
Original created: 2025-10-04T04:54:39Z
Original updated: 2025-10-04T04:57:00Z
Original head: carverauto/serviceradar:chore/fix_summarized_push_tags
Original base: main
Original merged: 2025-10-04T04:56:52Z by @mfreeman451

PR Type

Other

Description

Fix shell variable interpolation in Docker workflow
Replace direct parameter expansion with proper variable assignment

Diagram Walkthrough

flowchart LR
  A["Direct parameter expansion"] --> B["Variable assignment"]
  B --> C["Proper printf formatting"]

File Walkthrough

Relevant files

Bug fix

docker-build.yml

Fix shell variable interpolation in workflow

.github/workflows/docker-build.yml

Replace direct ${GITHUB_SHA:0:12} expansion in printf with variable
assignment
Use proper shell variable interpolation for SHA prefix formatting

+2/-1

Imported from GitHub pull request. Original GitHub pull request: #1694 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1694 Original created: 2025-10-04T04:54:39Z Original updated: 2025-10-04T04:57:00Z Original head: carverauto/serviceradar:chore/fix_summarized_push_tags Original base: main Original merged: 2025-10-04T04:56:52Z by @mfreeman451 --- ### **PR Type** Other ___ ### **Description** - Fix shell variable interpolation in Docker workflow - Replace direct parameter expansion with proper variable assignment ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Direct parameter expansion"] --> B["Variable assignment"] B --> C["Proper printf formatting"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>docker-build.yml</strong><dd><code>Fix shell variable interpolation in workflow</code>                          </dd></summary> <hr> .github/workflows/docker-build.yml <ul><li>Replace direct <code>${GITHUB_SHA:0:12}</code> expansion in printf with variable <br>assignment<br> <li> Use proper shell variable interpolation for SHA prefix formatting</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/1694/files#diff-3414847e2ad632333f775cabb810f0dc0df61a570365df34750a08b00912fe82">+2/-1</a>      </td> </tr> </table></td></tr></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2025-10-04 04:54:53 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1694#issuecomment-3367900565
Original created: 2025-10-04T04:54:53Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
⚪	No custom compliance provided Follow the guide to enable custom compliance check.

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1694#issuecomment-3367900565 Original created: 2025-10-04T04:54:53Z --- ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR:<br> <table><tbody><tr><td colspan='2'><strong>Security Compliance</strong></td></tr> <tr><td>🟢</td><td><details><summary><strong>No security concerns identified</strong></summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'><strong>Ticket Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary>🎫 <strong>No ticket provided </summary></strong> - [ ] Create ticket/issue  </details></td></tr> <tr><td colspan='2'><strong>Codebase Duplication Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary><strong>Codebase context is not defined </strong></summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'><strong>Custom Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary><strong>No custom compliance provided</strong></summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/'>guide</a> to enable custom compliance check. </details></td></tr> <tr><td align="center" colspan="2">   </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant<br> 🟡 - Partial Compliant<br> 🔴 - Not Compliant<br> ⚪ - Requires Further Human Verification<br> 🏷️ - Compliance label<br> </details>

qodo-code-review[bot] commented

2025-10-04 04:55:23 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1694#issuecomment-3367900844
Original created: 2025-10-04T04:55:23Z

PR Code Suggestions ✨

No code suggestions found for the PR.

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1694#issuecomment-3367900844 Original created: 2025-10-04T04:55:23Z --- ## PR Code Suggestions ✨ No code suggestions found for the PR.