Updates/srql security review #2225
No reviewers
Labels
No labels
1week
2weeks
Failed compliance check
IP cameras
NATS
Possible security concern
Review effort 1/5
Review effort 2/5
Review effort 3/5
Review effort 4/5
Review effort 5/5
UI
aardvark
accessibility
amd64
api
arm64
auth
back-end
bgp
blog
bug
build
checkers
ci-cd
cleanup
cnpg
codex
core
dependencies
device-management
documentation
duplicate
dusk
ebpf
enhancement
eta 1d
eta 1hr
eta 3d
eta 3hr
feature
fieldsurvey
github_actions
go
good first issue
help wanted
invalid
javascript
k8s
log-collector
mapper
mtr
needs-triage
netflow
network-sweep
observability
oracle
otel
plug-in
proton
python
question
reddit
redhat
research
rperf
rperf-checker
rust
sdk
security
serviceradar-agent
serviceradar-agent-gateway
serviceradar-web
serviceradar-web-ng
siem
snmp
sysmon
topology
ubiquiti
wasm
wontfix
zen-engine
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
carverauto/serviceradar!2225
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refs/pull/2225/head"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Imported from GitHub pull request.
Original GitHub pull request: #1643
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1643
Original created: 2025-09-16T15:58:55Z
Original updated: 2025-09-17T22:59:41Z
Original head: carverauto/serviceradar:updates/srql_security_review
Original base: main
Original merged: 2025-09-17T22:59:38Z by @mfreeman451
No description provided.
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268832
Original created: 2025-09-17T04:29:56Z
Original path: web/src/app/api/devices/snmp/status/route.ts
Original line: 102
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268834
Original created: 2025-09-17T04:29:56Z
Original path: web/src/app/api/devices/sysmon/status/route.ts
Original line: 101
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268837
Original created: 2025-09-17T04:29:56Z
Original path: web/src/components/Analytics/CriticalEventsWidget.tsx
Original line: 108
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268839
Original created: 2025-09-17T04:29:56Z
Original path: web/src/components/Analytics/CriticalLogsWidget.tsx
Original line: 126
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268840
Original created: 2025-09-17T04:29:56Z
Original path: web/src/components/Devices/Dashboard.tsx
Original line: 131
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268843
Original created: 2025-09-17T04:29:56Z
Original path: web/src/components/Events/Dashboard.tsx
Original line: 146
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268844
Original created: 2025-09-17T04:29:56Z
Original path: web/src/components/Logs/Dashboard.tsx
Original line: 231
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268846
Original created: 2025-09-17T04:29:56Z
Original path: web/src/components/Logs/Dashboard.tsx
Original line: 236
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268848
Original created: 2025-09-17T04:29:57Z
Original path: web/src/components/Logs/Dashboard.tsx
Original line: 268
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268849
Original created: 2025-09-17T04:29:57Z
Original path: web/src/components/Logs/Dashboard.tsx
Original line: 273
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268852
Original created: 2025-09-17T04:29:57Z
Original path: web/src/components/Network/Dashboard.tsx
Original line: 195
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268853
Original created: 2025-09-17T04:29:57Z
Original path: web/src/components/Observability/MetricsDashboard.tsx
Original line: 239
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268855
Original created: 2025-09-17T04:29:57Z
Original path: web/src/components/Observability/MetricsDashboard.tsx
Original line: 250
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268858
Original created: 2025-09-17T04:29:57Z
Original path: web/src/components/Observability/TracesDashboard.tsx
Original line: 258
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268859
Original created: 2025-09-17T04:29:57Z
Original path: web/src/components/Observability/TracesDashboard.tsx
Original line: 270
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268861
Original created: 2025-09-17T04:29:57Z
Original path: web/src/components/Observability/TracesDashboard.tsx
Original line: 327
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#discussion_r2354268862
Original created: 2025-09-17T04:29:57Z
Original path: web/src/components/Observability/TracesDashboard.tsx
Original line: 339
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
Show more details
Imported GitHub PR comment.
Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1643#issuecomment-3304777527
Original created: 2025-09-17T22:50:03Z
CI Feedback 🧐
A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
Action: build-test
Failed stage: Install dependencies (with tests) [❌]
Failure summary:
The action failed during opam dependency resolution due to incompatible OCaml compiler constraints:
- The environment requires
ocaml-base-compiler = 5.3.0(invariant), but dependencies pulled bydeps-of-srql-translator→dream→dream-httpaf→h2 < 0.13.0requireocaml < 5.0, conflicting withOCaml 5.3.0.
- Resulting conflicts involved
dkml-base-compiler/ocaml-variantsandh2-lwt-unixwithtlsconstraints.- Missing dependencies also surfaced (
ocaml-betaneedingenable-ocaml-beta-repository, andsystem-msvcrestricted toos = "win32"), further preventingresolution.
- opam exited with code 20 due to the unsatisfiable package set.
Relevant error logs: