1595 featui admin interface #2190
No reviewers
Labels
No labels
1week
2weeks
Failed compliance check
IP cameras
NATS
Possible security concern
Review effort 1/5
Review effort 2/5
Review effort 3/5
Review effort 4/5
Review effort 5/5
UI
aardvark
accessibility
amd64
api
arm64
auth
back-end
bgp
blog
bug
build
checkers
ci-cd
cleanup
cnpg
codex
core
dependencies
device-management
documentation
duplicate
dusk
ebpf
enhancement
eta 1d
eta 1hr
eta 3d
eta 3hr
feature
fieldsurvey
github_actions
go
good first issue
help wanted
invalid
javascript
k8s
log-collector
mapper
mtr
needs-triage
netflow
network-sweep
observability
oracle
otel
plug-in
proton
python
question
reddit
redhat
research
rperf
rperf-checker
rust
sdk
security
serviceradar-agent
serviceradar-agent-gateway
serviceradar-web
serviceradar-web-ng
siem
snmp
sysmon
topology
ubiquiti
wasm
wontfix
zen-engine
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
carverauto/serviceradar!2190
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refs/pull/2190/head"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Imported from GitHub pull request.
Original GitHub pull request: #1606
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1606
Original created: 2025-09-02T22:16:27Z
Original updated: 2025-09-03T18:18:22Z
Original head: carverauto/serviceradar:1595-featui-admin-interface
Original base: main
Original merged: 2025-09-03T18:18:18Z by @mfreeman451
No description provided.
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317296255
Original created: 2025-09-02T22:18:19Z
Original path: web/src/components/Admin/ConfigForms/AgentConfigForm.tsx
Original line: 69
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317296260
Original created: 2025-09-02T22:18:19Z
Original path: web/src/components/Admin/ConfigForms/CoreConfigForm.tsx
Original line: 135
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317296262
Original created: 2025-09-02T22:18:19Z
Original path: web/src/components/Admin/ConfigForms/PollerConfigForm.tsx
Original line: 74
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317296266
Original created: 2025-09-02T22:18:19Z
Original path: web/src/components/Admin/ConfigForms/SyncConfigForm.tsx
Original line: 63
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317692457
Original created: 2025-09-03T03:58:12Z
Original path: web/src/components/Admin/ConfigForms/AgentConfigForm.tsx
Original line: 69
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317692458
Original created: 2025-09-03T03:58:12Z
Original path: web/src/components/Admin/ConfigForms/CoreConfigForm.tsx
Original line: 135
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317692459
Original created: 2025-09-03T03:58:12Z
Original path: web/src/components/Admin/ConfigForms/PollerConfigForm.tsx
Original line: 74
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317692460
Original created: 2025-09-03T03:58:12Z
Original path: web/src/components/Admin/ConfigForms/SyncConfigForm.tsx
Original line: 63
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317764536
Original created: 2025-09-03T05:00:59Z
Original path: pkg/core/auth/auth.go
Original line: 118
risky
Imported GitHub PR review comment.
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317848526
Original created: 2025-09-03T06:01:37Z
Original path: pkg/core/config.go
Original line: 91
not sure why we're loading stuff from env here
Imported GitHub PR review comment.
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317870533
Original created: 2025-09-03T06:15:55Z
Original path: web/src/hooks/useRBAC.ts
Original line: 1
this should be removed we are doing RBAC in the API not in the web
Imported GitHub PR review comment.
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2317871247
Original created: 2025-09-03T06:16:23Z
Original path: web/src/middleware/rbac.ts
Original line: 1
needs to be removed, RBAC done at API
Imported GitHub PR review comment.
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2319412524
Original created: 2025-09-03T15:53:24Z
Original path: pkg/core/config.go
Original line: 91
resolved
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2319486637
Original created: 2025-09-03T16:22:03Z
Original path: pkg/db/db.go
Original line: 242
Size computation for allocation may overflow
This operation, which is used in an allocation, involves a potentially large value and might overflow.
This operation, which is used in an allocation, involves a potentially large value and might overflow.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2319525053
Original created: 2025-09-03T16:39:18Z
Original path: web/src/components/Admin/ConfigForms/AgentConfigForm.tsx
Original line: 92
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2319525060
Original created: 2025-09-03T16:39:18Z
Original path: web/src/components/Admin/ConfigForms/CoreConfigForm.tsx
Original line: 158
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2319525062
Original created: 2025-09-03T16:39:18Z
Original path: web/src/components/Admin/ConfigForms/PollerConfigForm.tsx
Original line: 97
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2319525064
Original created: 2025-09-03T16:39:18Z
Original path: web/src/components/Admin/ConfigForms/SyncConfigForm.tsx
Original line: 86
Prototype-polluting function
The property chain here is recursively assigned to current without guarding against prototype pollution.
Show more details
Imported GitHub PR review comment.
Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1606#discussion_r2319708473
Original created: 2025-09-03T17:33:16Z
Original path: pkg/db/db.go
Original line: 248
Size computation for allocation may overflow
This operation, which is used in an allocation, involves a potentially large value and might overflow.
This operation, which is used in an allocation, involves a potentially large value and might overflow.
Show more details