Return alternate IPs as metadata array #1786

Merged

mfreeman451 merged 1 commit from refs/pull/1786/head into 994-featcore-support-for-partitions

2025-06-21 00:23:19 +00:00

mfreeman451 commented

2025-06-21 00:18:27 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #1013
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1013
Original created: 2025-06-21T00:18:27Z
Original updated: 2025-06-21T00:23:22Z
Original head: carverauto/serviceradar:codex/return-alternate-ips-in-array
Original base: 994-featcore-support-for-partitions
Original merged: 2025-06-21T00:23:19Z by @mfreeman451

Summary

roll back protobuf change and drop wrappers proto
keep alternate IP addresses under a single alternate_ips metadata key
store the metadata value as a JSON array when merging devices
update polling logic and tests to use new helper

Testing

go vet ./... (fails: unreachable code in generated parser files)
go test ./...

https://chatgpt.com/codex/tasks/task_e_6855f07579888320837069d2d5a82e4f

Imported from GitHub pull request. Original GitHub pull request: #1013 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1013 Original created: 2025-06-21T00:18:27Z Original updated: 2025-06-21T00:23:22Z Original head: carverauto/serviceradar:codex/return-alternate-ips-in-array Original base: 994-featcore-support-for-partitions Original merged: 2025-06-21T00:23:19Z by @mfreeman451 --- ## Summary - roll back protobuf change and drop wrappers proto - keep alternate IP addresses under a single `alternate_ips` metadata key - store the metadata value as a JSON array when merging devices - update polling logic and tests to use new helper ## Testing - `go vet ./...` *(fails: unreachable code in generated parser files)* - `go test ./...` ------ https://chatgpt.com/codex/tasks/task_e_6855f07579888320837069d2d5a82e4f