Handle batch append errors correctly #1750

Merged
mfreeman451 merged 1 commit from refs/pull/1750/head into 800-live-armis-poc-integration-into-serviceradar 2025-06-19 01:50:25 +00:00
mfreeman451 commented 2025-06-19 01:43:52 +00:00 (Migrated from github.com)
Owner

Imported from GitHub pull request.

Original GitHub pull request: #974
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/974
Original created: 2025-06-19T01:43:52Z
Original updated: 2025-06-19T01:50:29Z
Original head: carverauto/serviceradar:codex/fix-nil-pointer-dereference-in-device-manager
Original base: 800-live-armis-poc-integration-into-serviceradar
Original merged: 2025-06-19T01:50:25Z by @mfreeman451

Summary

  • fix device batch insertion logic to abort and return errors when append fails
  • explicitly define columns for device insert to avoid argument mismatch

Testing

  • go test ./...

https://chatgpt.com/codex/tasks/task_e_68535cf6f9d08320ab2837b6cbb1ab39

Imported from GitHub pull request. Original GitHub pull request: #974 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/974 Original created: 2025-06-19T01:43:52Z Original updated: 2025-06-19T01:50:29Z Original head: carverauto/serviceradar:codex/fix-nil-pointer-dereference-in-device-manager Original base: 800-live-armis-poc-integration-into-serviceradar Original merged: 2025-06-19T01:50:25Z by @mfreeman451 --- ## Summary - fix device batch insertion logic to abort and return errors when append fails - explicitly define columns for device insert to avoid argument mismatch ## Testing - `go test ./...` ------ https://chatgpt.com/codex/tasks/task_e_68535cf6f9d08320ab2837b6cbb1ab39
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!1750
No description provided.