Fix netbox sweep config crash #1738

Merged
mfreeman451 merged 1 commit from refs/pull/1738/head into 800-live-armis-poc-integration-into-serviceradar 2025-06-18 16:59:36 +00:00
mfreeman451 commented 2025-06-18 16:59:15 +00:00 (Migrated from github.com)
Owner

Imported from GitHub pull request.

Original GitHub pull request: #962
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/962
Original created: 2025-06-18T16:59:15Z
Original updated: 2025-06-18T16:59:39Z
Original head: carverauto/serviceradar:codex/fix-mtls-nil-pointer-dereference
Original base: 800-live-armis-poc-integration-into-serviceradar
Original merged: 2025-06-18T16:59:36Z by @mfreeman451

Summary

  • check KvClient in netbox integration before writing sweep config

Testing

  • go test ./pkg/sync/...
  • go test ./... (fails: TestSNMPService missing call)

https://chatgpt.com/codex/tasks/task_e_6852ef01b6188320aff86924429aa92e

Imported from GitHub pull request. Original GitHub pull request: #962 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/962 Original created: 2025-06-18T16:59:15Z Original updated: 2025-06-18T16:59:39Z Original head: carverauto/serviceradar:codex/fix-mtls-nil-pointer-dereference Original base: 800-live-armis-poc-integration-into-serviceradar Original merged: 2025-06-18T16:59:36Z by @mfreeman451 --- ## Summary - check KvClient in netbox integration before writing sweep config ## Testing - `go test ./pkg/sync/...` - `go test ./...` *(fails: TestSNMPService missing call)* ------ https://chatgpt.com/codex/tasks/task_e_6852ef01b6188320aff86924429aa92e
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!1738
No description provided.