516 integration with web UI #1447

Merged

mfreeman451 merged 14 commits from refs/pull/1447/head into main

2025-04-03 00:37:14 +00:00

mfreeman451 commented

2025-04-02 23:08:10 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #519
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/519
Original created: 2025-04-02T23:08:10Z
Original updated: 2025-04-03T00:37:17Z
Original head: carverauto/serviceradar:516-integration-with-web-ui
Original base: main
Original merged: 2025-04-03T00:37:14Z by @mfreeman451

No description provided.

Imported from GitHub pull request. Original GitHub pull request: #519 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/519 Original created: 2025-04-02T23:08:10Z Original updated: 2025-04-03T00:37:17Z Original head: carverauto/serviceradar:516-integration-with-web-ui Original base: main Original merged: 2025-04-03T00:37:14Z by @mfreeman451 --- _No description provided._

mfreeman451 commented

2025-04-03 00:23:46 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/519#discussion_r2025813965
Original created: 2025-04-03T00:23:46Z
Original path: pkg/core/server.go
Original line: 88

interface pollution, need to revisit this

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/519#discussion_r2025813965 Original created: 2025-04-03T00:23:46Z Original path: pkg/core/server.go Original line: 88 --- interface pollution, need to revisit this

mfreeman451 commented

2025-04-03 00:25:02 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/519#discussion_r2025814725
Original created: 2025-04-03T00:25:02Z
Original path: pkg/core/types.go
Original line: 123

interface pollution, should take a closure or something

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/519#discussion_r2025814725 Original created: 2025-04-03T00:25:02Z Original path: pkg/core/types.go Original line: 123 --- interface pollution, should take a closure or something

mfreeman451 commented

2025-04-03 00:27:56 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/519#discussion_r2025816386
Original created: 2025-04-03T00:27:56Z
Original path: web/next.config.ts
Original line: 36

not sure if this is good or bad yet.

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/519#discussion_r2025816386 Original created: 2025-04-03T00:27:56Z Original path: web/next.config.ts Original line: 36 --- not sure if this is good or bad yet.