Feature/local auth web #1356

Merged

mfreeman451 merged 46 commits from refs/pull/1356/head into main

2025-03-21 13:32:17 +00:00

mfreeman451 commented

2025-03-21 01:57:29 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #375
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/375
Original created: 2025-03-21T01:57:29Z
Original updated: 2025-03-21T13:32:20Z
Original head: carverauto/serviceradar:feature/local_auth_web
Original base: main
Original merged: 2025-03-21T13:32:17Z by @mfreeman451

No description provided.

Imported from GitHub pull request. Original GitHub pull request: #375 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/375 Original created: 2025-03-21T01:57:29Z Original updated: 2025-03-21T13:32:20Z Original head: carverauto/serviceradar:feature/local_auth_web Original base: main Original merged: 2025-03-21T13:32:17Z by @mfreeman451 --- _No description provided._

github-advanced-security[bot] commented

2025-03-21 01:59:43 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/375#discussion_r2006723208
Original created: 2025-03-21T01:59:43Z
Original path: pkg/core/auth/auth.go
Original line: 69

Clear-text logging of sensitive information

Sensitive data returned by an access to password flows to a logging call.

Show more details

Imported GitHub PR review comment. Original author: @github-advanced-security[bot] Original URL: https://github.com/carverauto/serviceradar/pull/375#discussion_r2006723208 Original created: 2025-03-21T01:59:43Z Original path: pkg/core/auth/auth.go Original line: 69 --- ## Clear-text logging of sensitive information [Sensitive data returned by an access to password](1) flows to a logging call. [Show more details](https://github.com/carverauto/serviceradar/security/code-scanning/17)

mfreeman451 commented

2025-03-21 02:03:43 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/375#discussion_r2006726476
Original created: 2025-03-21T02:03:43Z
Original path: pkg/http/middleware.go
Original line: 27

need to pull this in from a config value

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/375#discussion_r2006726476 Original created: 2025-03-21T02:03:43Z Original path: pkg/http/middleware.go Original line: 27 --- need to pull this in from a config value

mfreeman451 commented

2025-03-21 13:09:19 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/375#discussion_r2007550027
Original created: 2025-03-21T13:09:19Z
Original path: web/src/app/login/page.tsx
Original line: 34

seems broken

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/375#discussion_r2007550027 Original created: 2025-03-21T13:09:19Z Original path: web/src/app/login/page.tsx Original line: 34 --- seems broken

mfreeman451 commented

2025-03-21 13:09:46 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/375#discussion_r2007550722
Original created: 2025-03-21T13:09:46Z
Original path: web/src/app/nodes/page.tsx
Original line: 35

theres probably a more next-centric way to do this

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/375#discussion_r2007550722 Original created: 2025-03-21T13:09:46Z Original path: web/src/app/nodes/page.tsx Original line: 35 --- theres probably a more next-centric way to do this